From: Suman Ghosh <sumang@marvell.com>
To: <sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <hkelam@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
<jerinj@marvell.com>, <markus.elfring@web.de>
Cc: Suman Ghosh <sumang@marvell.com>
Subject: [net PATCH 3/7] octeontx2-af: Fixes klockwork issues in ptp.c
Date: Mon, 24 Jun 2024 16:06:34 +0530 [thread overview]
Message-ID: <20240624103638.2087821-4-sumang@marvell.com> (raw)
In-Reply-To: <20240624103638.2087821-1-sumang@marvell.com>
These are not real issues but sanity checks.
Fixes: 4086f2a06a35 ("octeontx2-af: Add support for Marvell PTP coprocessor")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/af/ptp.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
index bcc96eed2481..0be5d22d213b 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
@@ -517,6 +517,7 @@ static int ptp_pps_on(struct ptp *ptp, int on, u64 period)
static int ptp_probe(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
+ void __iomem * const *base;
struct ptp *ptp;
int err;
@@ -536,7 +537,15 @@ static int ptp_probe(struct pci_dev *pdev,
if (err)
goto error_free;
- ptp->reg_base = pcim_iomap_table(pdev)[PCI_PTP_BAR_NO];
+ base = pcim_iomap_table(pdev);
+ if (!base)
+ goto error_free;
+
+ ptp->reg_base = base[PCI_PTP_BAR_NO];
+ if (!ptp->reg_base) {
+ err = -ENODEV;
+ goto error_free;
+ }
pci_set_drvdata(pdev, ptp);
if (!first_ptp_block)
--
2.25.1
next prev parent reply other threads:[~2024-06-24 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 10:36 [net PATCH 0/7] octeontx2-af: Fix klockwork issues in AF driver Suman Ghosh
2024-06-24 10:36 ` [net PATCH 1/7] octeontx2-af: Fix klockwork issue in cgx.c Suman Ghosh
2024-06-24 12:11 ` Markus Elfring
2024-06-24 10:36 ` [net PATCH 2/7] octeontx2-af: Fix klockwork issues in mcs_rvu_if.c Suman Ghosh
2024-06-24 10:36 ` Suman Ghosh [this message]
2024-06-24 10:36 ` [net PATCH 4/7] octeontx2-af: Fixes klockwork issues in rvu_cpt.c Suman Ghosh
2024-06-24 10:36 ` [net PATCH 5/7] octeontx2-af: Fixes klockwork issues in rvu_debugfs.c Suman Ghosh
2024-06-24 10:36 ` [net PATCH 6/7] octeontx2-af: Fix klockwork issue in rvu_nix.c Suman Ghosh
2024-06-24 10:36 ` [net PATCH 7/7] octeontx2-af: Fix klockwork issue in rvu_npc.c Suman Ghosh
2024-06-24 11:13 ` [net PATCH 0/7] octeontx2-af: Fix klockwork issues in AF driver Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624103638.2087821-4-sumang@marvell.com \
--to=sumang@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).