netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] selftests: net: remove unneeded IP_GRE config
@ 2024-06-24  5:55 Yujie Liu
  2024-06-24 23:31 ` Jakub Kicinski
  2024-06-25 15:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Yujie Liu @ 2024-06-24  5:55 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Shuah Khan, netdev,
	linux-kselftest, linux-kernel, kernel test robot

It seems that there is no definition for config IP_GRE, and it is not a
dependency of other configs, so remove it.

linux$ find -name Kconfig | xargs grep "IP_GRE"
<-- nothing

There is a IPV6_GRE config defined in net/ipv6/Kconfig. It only depends
on NET_IPGRE_DEMUX but not IP_GRE.

Fixes: 04fe7c5029cb ("selftests: fill in some missing configs for net")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 tools/testing/selftests/net/config | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index d4891f7a2bfa..f46e27cd1e70 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -26,7 +26,6 @@ CONFIG_INET_ESP=y
 CONFIG_INET_ESP_OFFLOAD=y
 CONFIG_NET_FOU=y
 CONFIG_NET_FOU_IP_TUNNELS=y
-CONFIG_IP_GRE=m
 CONFIG_NETFILTER=y
 CONFIG_NETFILTER_ADVANCED=y
 CONFIG_NF_CONNTRACK=m
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: net: remove unneeded IP_GRE config
  2024-06-24  5:55 [PATCH net] selftests: net: remove unneeded IP_GRE config Yujie Liu
@ 2024-06-24 23:31 ` Jakub Kicinski
  2024-06-25 15:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-06-24 23:31 UTC (permalink / raw)
  To: Yujie Liu
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Shuah Khan, netdev,
	linux-kselftest, linux-kernel, kernel test robot

On Mon, 24 Jun 2024 13:55:39 +0800 Yujie Liu wrote:
> It seems that there is no definition for config IP_GRE, and it is not a
> dependency of other configs, so remove it.
> 
> linux$ find -name Kconfig | xargs grep "IP_GRE"
> <-- nothing
> 
> There is a IPV6_GRE config defined in net/ipv6/Kconfig. It only depends
> on NET_IPGRE_DEMUX but not IP_GRE.
> 
> Fixes: 04fe7c5029cb ("selftests: fill in some missing configs for net")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>

Patch makes sense, that said it's harmless so I'd suggest net-next.

Acked-by: Jakub Kicinski <kuba@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: net: remove unneeded IP_GRE config
  2024-06-24  5:55 [PATCH net] selftests: net: remove unneeded IP_GRE config Yujie Liu
  2024-06-24 23:31 ` Jakub Kicinski
@ 2024-06-25 15:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-25 15:50 UTC (permalink / raw)
  To: Yujie Liu
  Cc: kuba, davem, edumazet, pabeni, shuah, netdev, linux-kselftest,
	linux-kernel, lkp

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 24 Jun 2024 13:55:39 +0800 you wrote:
> It seems that there is no definition for config IP_GRE, and it is not a
> dependency of other configs, so remove it.
> 
> linux$ find -name Kconfig | xargs grep "IP_GRE"
> <-- nothing
> 
> There is a IPV6_GRE config defined in net/ipv6/Kconfig. It only depends
> on NET_IPGRE_DEMUX but not IP_GRE.
> 
> [...]

Here is the summary with links:
  - [net] selftests: net: remove unneeded IP_GRE config
    https://git.kernel.org/netdev/net-next/c/c4532232fa2a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-25 15:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24  5:55 [PATCH net] selftests: net: remove unneeded IP_GRE config Yujie Liu
2024-06-24 23:31 ` Jakub Kicinski
2024-06-25 15:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).