From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
David Howells <dhowells@redhat.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] net: allow skb_datagram_iter to be called from any context
Date: Tue, 25 Jun 2024 07:10:28 -0700 [thread overview]
Message-ID: <20240625071028.2324a9f5@kernel.org> (raw)
In-Reply-To: <1c5f5650ba2ffe99b068266ceb6e69f59661563f.camel@redhat.com>
On Tue, 25 Jun 2024 15:27:41 +0200 Paolo Abeni wrote:
> On Sun, 2024-06-23 at 11:12 +0300, Sagi Grimberg wrote:
> > We only use the mapping in a single context, so kmap_local is sufficient
> > and cheaper. Make sure to use skb_frag_foreach_page as skb frags may
> > contain highmem compound pages and we need to map page by page.
> >
> > Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
>
> V1 is already applied to net-next, you need to either send a revert
> first or share an incremental patch (that would be a fix, and will need
> a fixes tag).
>
> On next revision, please include the target tree in the subj prefix.
I think the bug exists in net (it just requires an arch with HIGHMEM
to be hit). So send the fix based on net/master and we'll deal with
the net-next conflict? Or you can send a revert for net-next at the
same time, but I think the fix should target net.
next prev parent reply other threads:[~2024-06-25 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 8:12 [PATCH v2] net: allow skb_datagram_iter to be called from any context Sagi Grimberg
2024-06-23 13:44 ` Sagi Grimberg
2024-06-25 13:27 ` Paolo Abeni
2024-06-25 14:10 ` Jakub Kicinski [this message]
2024-06-25 14:40 ` Eric Dumazet
2024-06-27 15:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625071028.2324a9f5@kernel.org \
--to=kuba@kernel.org \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).