From: Jakub Kicinski <kuba@kernel.org>
To: Aaron Conole <aconole@redhat.com>
Cc: "Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
"Pravin B Shelar" <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Shuah Khan" <shuah@kernel.org>,
"Stefano Brivio" <sbrivio@redhat.com>,
"Adrián Moreno" <amorenoz@redhat.com>,
"Simon Horman" <horms@kernel.org>
Subject: Re: [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.
Date: Tue, 25 Jun 2024 07:41:45 -0700 [thread overview]
Message-ID: <20240625074145.69fc9d9f@kernel.org> (raw)
In-Reply-To: <f7t1q4lgldr.fsf@redhat.com>
On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote:
> > Sorry for not checking it earlier, looks like the runner was missing
> > pyroute:
> >
> > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py
> > Need to install the python pyroute2 package >= 0.6.
> >
> > I guess run_cmd counter-productively eats the stderr output ? :(
>
> Awesome :) I will add a patch to ovs-dpctl that will turn the
> sys.exit(0) into sys.exit(1) - that way it should do the skip.
>
> When I previously tested, I put an error in the `try` without reading
> the except being specifically for a ModuleNotFound error.
>
> I'll make sure pyroute2 isn't installed when I run it again.
>
> Thanks for your help Jakub and Paolo!
BTW I popped the v2 back into the queue, so the next run (in 20min)
will tell us if that's the only thing we were missing 🤞️
next prev parent reply other threads:[~2024-06-25 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 12:55 [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script Aaron Conole
2024-06-20 12:55 ` [PATCH v2 net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation Aaron Conole
2024-06-20 12:55 ` [PATCH v2 net-next 2/7] selftests: openvswitch: Refactor actions parsing Aaron Conole
2024-06-20 12:55 ` [PATCH v2 net-next 3/7] selftests: openvswitch: Add set() and set_masked() support Aaron Conole
2024-06-20 12:55 ` [PATCH v2 net-next 4/7] selftests: openvswitch: Add support for tunnel() key Aaron Conole
2024-06-20 12:55 ` [PATCH v2 net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments Aaron Conole
2024-06-20 12:56 ` [PATCH v2 net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests Aaron Conole
2024-06-20 12:56 ` [PATCH v2 net-next 7/7] selftests: net: add config for openvswitch Aaron Conole
2024-06-22 1:01 ` [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script Jakub Kicinski
2024-06-23 19:26 ` Aaron Conole
2024-06-24 16:53 ` Aaron Conole
2024-06-24 22:30 ` Jakub Kicinski
2024-06-25 9:52 ` Stefano Brivio
2024-06-25 13:18 ` Aaron Conole
2024-06-25 8:27 ` Paolo Abeni
2024-06-25 13:20 ` Aaron Conole
2024-06-25 14:06 ` Jakub Kicinski
2024-06-25 14:14 ` Aaron Conole
2024-06-25 14:41 ` Jakub Kicinski [this message]
2024-06-25 15:17 ` Aaron Conole
2024-06-25 16:30 ` Jakub Kicinski
2024-06-25 15:41 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625074145.69fc9d9f@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=sbrivio@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).