From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3821B16FF31; Tue, 25 Jun 2024 14:41:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719326507; cv=none; b=DUzHy2qAp/Ar6da/qslb7BKGvtoCa1URkz2GJCKHaPJWbKRy3alYqnCNSwKeFJ1HaU9sUIewDq76zvMibnCws3pFIGRPhxp5UgBankUU1srbPJWPZuFsUMLkPWLhBYk5wdc0jLB7V0EbhIOMTmwnQcWLip4cNFLeIiO7+skm14M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719326507; c=relaxed/simple; bh=7Xoqa/8SM4/teyTc5YVyyz/aN2GVZH2+fbzkHrtRClc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sBhvIYbqzKRv3jEIPteWqV1W1We9hjGBjWqUNBxMlKqCBWMXAJhYSmv5+89ukKuewOWfCWlP3yS8fBh8m4qjYILcX4iGGYApbdbbGoQB/2ywQ/XefEaFfeaXs2lsU8KVGRbVN0CGFujYoTG7kWZcwTbZLXXswrdQU5H+wXcas50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kl0mNoxN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kl0mNoxN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31C7CC32786; Tue, 25 Jun 2024 14:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719326506; bh=7Xoqa/8SM4/teyTc5YVyyz/aN2GVZH2+fbzkHrtRClc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kl0mNoxN/PcCwlqXY6XVVhDiKjRsivVxEBgCN5Wt06JThBYPf9EN05TzDJE8AV0W8 +h6qlKhJCJZ3ZL/aMcxIE841wgMP3Hkm+reT3vl0Ivw5ir9Dhe/nulXdu0gBTdT9pl 3k2PbH4g+FI8s42V9hIiatJMk3tb4HnaSYF3jWYbjYOwKA94pjBW1ZjTcnfAKWawNt pdGo2OM7YrVXnreO9yEdUgj5474Clp9VqFrtqIZ1WLtyZlfJZ8SqnG0lRBttK3NqQk C61DFIL2qme0jd4ThkSt9psSznSPHi9tlQYeAW0Q3MxCZOpBjTXPLFnmIerpw/Cc91 lH7a4uWEEnmsQ== Date: Tue, 25 Jun 2024 07:41:45 -0700 From: Jakub Kicinski To: Aaron Conole Cc: Paolo Abeni , netdev@vger.kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Pravin B Shelar , "David S. Miller" , Eric Dumazet , Shuah Khan , Stefano Brivio , =?UTF-8?B?QWRyacOhbg==?= Moreno , Simon Horman Subject: Re: [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script. Message-ID: <20240625074145.69fc9d9f@kernel.org> In-Reply-To: References: <20240620125601.15755-1-aconole@redhat.com> <20240621180126.3c40d245@kernel.org> <20240625070654.6a00efef@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote: > > Sorry for not checking it earlier, looks like the runner was missing > > pyroute: > > > > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py > > Need to install the python pyroute2 package >=3D 0.6. > > > > I guess run_cmd counter-productively eats the stderr output ? :( =20 >=20 > Awesome :) I will add a patch to ovs-dpctl that will turn the > sys.exit(0) into sys.exit(1) - that way it should do the skip. >=20 > When I previously tested, I put an error in the `try` without reading > the except being specifically for a ModuleNotFound error. >=20 > I'll make sure pyroute2 isn't installed when I run it again. >=20 > Thanks for your help Jakub and Paolo! BTW I popped the v2 back into the queue, so the next run (in 20min) will tell us if that's the only thing we were missing =F0=9F=A4=9E=EF=B8=8F