From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9320146A64 for ; Tue, 25 Jun 2024 23:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719357429; cv=none; b=MWcs8jl/0DD6trHLVuIyVpWXExYsOZgOcYUjBYXSqkz30lSMM2A7EIrMSDUtehvcAvvBUIyx2ltLgNOTTIQeRLuRZ/xMB6KRKuieHxP3htUhIsVEJKFHnc7b6HWAmtoEgNMjTHqfMkODcvcQm6xVTwS7S4TOcO+TiZi7qynjOUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719357429; c=relaxed/simple; bh=cQMYxRyVTXxLQev4l9DTh3+BNG7mEy5YO2l5igcvI3w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cp6kjXic1JrQibTj8/yP8LbCYOl6twg9r+LloQrBzzxBziLNUus/kgALxdyL2XpWjJESTYqh73siycpKCNpJoUeOQ4n3LazMU46lozuxVVYy451N1Qom6QZVD++Ctr16GmUbfsm9hGFA9f6KtrPeN7Veoaj/W4ZGF92CVBtP5+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QKQy0p8z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QKQy0p8z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6629C32781; Tue, 25 Jun 2024 23:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719357429; bh=cQMYxRyVTXxLQev4l9DTh3+BNG7mEy5YO2l5igcvI3w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QKQy0p8z1qIscrERxkW+LxZJm3soIgsrRLvNHJYTp60TrWthA3TAVaiyuCs+eZPKg YPyouXrmjuMg51t7aRKMuGoAMMGy/ipOKyOQErGbO0mYpWIv/NCxgJZDd52czRVO0P 9bwKa6oXbPBu3znPkdyRFsbojfBP+UxMVg82WCNMkv79mUCn47ZLIRUQ38uttyYRUm k5AuuVZS0r6FQ5+15U4KhsA9qyZT0uUiA2KGBBva7o7r2P0rnWsK7oJtuEaKhUPqct 2O//bDlSteIzWpM28BGiuJZYuXWO9EddoVnXqa8e77mNXgqB1ToLhypOTrQAjz8jWC ohh5oDrPjWbQg== Date: Tue, 25 Jun 2024 16:17:07 -0700 From: Jakub Kicinski To: "Singhai, Anjali" Cc: Willem de Bruijn , "netdev@vger.kernel.org" , Paolo Abeni , Boris Pismenny , "gal@nvidia.com" , "cratiu@nvidia.com" , "rrameshbabu@nvidia.com" , "steffen.klassert@secunet.com" , "tariqt@nvidia.com" , "Samudrala, Sridhar" , "Acharya, Arun Kumar" Subject: Re: [RFC net-next 00/15] add basic PSP encryption for TCP connections Message-ID: <20240625161707.07642769@kernel.org> In-Reply-To: References: <66729953651ba_2751bc294fa@willemb.c.googlers.com.notmuch> <20240621173043.4afac43f@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 25 Jun 2024 22:05:13 +0000 Singhai, Anjali wrote: > 1. Master key rotation, this needs to be not just from top but also > from device side because of the master key sharing in some cases and > a common SPI space that can roll over. So need to have an event > mechanism from device driver back to kernel for key rotation. Please > add this. Sorry I don't need it myself, you'll need to add that once my patches are merged. > 2. Header additions in the driver, for now we can do this, but > ideally it should move to the stack, so that it can be common for all > devices. That's fair, I only have mlx5 implementation so I wasn't sure how much of it is reusable. Once we have 2 drivers we can extrapolate?