From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: syzbot <syzbot+608a2acde8c5a101d07d@syzkaller.appspotmail.com>
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, davem@davemloft.net, dsahern@kernel.org,
eddyz87@gmail.com, edumazet@google.com, haoluo@google.com,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
martin.lau@linux.dev, netdev@vger.kernel.org, pabeni@redhat.com,
sdf@fomichev.me, sdf@google.com, song@kernel.org,
syzkaller-bugs@googlegroups.com, yonghong.song@linux.dev
Subject: Re: [syzbot] [bpf?] [net?] WARNING in bpf_lwt_seg6_adjust_srh
Date: Tue, 25 Jun 2024 19:06:06 +0200 [thread overview]
Message-ID: <20240625170606.Ed9u123U@linutronix.de> (raw)
In-Reply-To: <000000000000571681061bb9b5ad@google.com>
On 2024-06-25 09:51:25 [-0700], syzbot wrote:
> Hello,
Hi,
…
> commit d1542d4ae4dfdc47c9b3205ebe849ed23af213dd
> Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Date: Thu Jun 20 13:22:02 2024 +0000
>
> seg6: Use nested-BH locking for seg6_bpf_srh_states.
…
> WARNING: CPU: 0 PID: 5091 at net/core/filter.c:6579 ____bpf_lwt_seg6_adjust_srh net/core/filter.c:6579 [inline]
> WARNING: CPU: 0 PID: 5091 at net/core/filter.c:6579 bpf_lwt_seg6_adjust_srh+0x877/0xb30 net/core/filter.c:6568
…
> Call Trace:
> <TASK>
> bpf_prog_2088341bddeddc1d+0x40/0x42
> bpf_dispatcher_nop_func include/linux/bpf.h:1243 [inline]
> __bpf_prog_run include/linux/filter.h:691 [inline]
> bpf_prog_run include/linux/filter.h:698 [inline]
> bpf_test_run+0x4f0/0xa90 net/bpf/test_run.c:432
> bpf_prog_test_run_skb+0xafa/0x13b0 net/bpf/test_run.c:1081
> bpf_prog_test_run+0x33a/0x3b0 kernel/bpf/syscall.c:4313
> __sys_bpf+0x48d/0x810 kernel/bpf/syscall.c:5728
> __do_sys_bpf kernel/bpf/syscall.c:5817 [inline]
> __se_sys_bpf kernel/bpf/syscall.c:5815 [inline]
> __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5815
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
I assumed this can only originate from input_action_end_bpf() but
clearly this not a hard requirement based on the report.
So this a valid invocation and it should not have been killer earlier in
the stack?
Sebastian
next prev parent reply other threads:[~2024-06-25 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 16:51 [syzbot] [bpf?] [net?] WARNING in bpf_lwt_seg6_adjust_srh syzbot
2024-06-25 17:06 ` Sebastian Andrzej Siewior [this message]
2024-07-05 10:41 ` [PATCH bpf-next] seg6: Ensure that seg6_bpf_srh_states can only be accessed from input_action_end_bpf() Sebastian Andrzej Siewior
2024-07-09 0:03 ` Martin KaFai Lau
2024-07-09 5:18 ` Sebastian Andrzej Siewior
2024-07-09 18:24 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625170606.Ed9u123U@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=syzbot+608a2acde8c5a101d07d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).