From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B31E53AD for ; Wed, 26 Jun 2024 00:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719362600; cv=none; b=g6JKFzvqYs0MxgOemcBF5KDutI/L0gT/fyYBKJ610T2bLrmguIKepJojwZ1xVL0MQFVUdKvgnQBHyACIz0b2N5L07qtDgmi7g8LdKwe5Mpdt2/xfAWtE11gmA6JORXu2pHXwc3TPr8UVp55FUp2kWskn5TMjoL+IVv1zLsH2HnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719362600; c=relaxed/simple; bh=6Si5gznrl1TBB/UR9O/vHFJ/6vjoWHGW2q4AHOPR3/8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J8mJKNTxi+7MkxHIhRqkQURZfFgjHkhLajOPjjRUlDHIX8G9JgwzHzDpCXAyUA+ZFMQwAs9MGOoLKbYe8ngRReBq6tFDIAMKycX9fP59RiOQp4OULSe0sSrfJfIS7gnXxpND1dfwTaWuXdu3jzxC0mLTEQYyq9OWvhyomeS7FMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IZr+u1mw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IZr+u1mw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5398C32781; Wed, 26 Jun 2024 00:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719362600; bh=6Si5gznrl1TBB/UR9O/vHFJ/6vjoWHGW2q4AHOPR3/8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IZr+u1mw6jH9c04/NnApiBLYAnVImI6e1QtddFN1O8+UTF7OxmZFR/AELS/yqv3RE iUp78CfWbdA7V/xkd92ZKFu/h/6x2TJBI+JnqJLQClofhnSL4VhLiBvHAJvJsDvyEF B67aVXr9OVQJkB0XHF6JaxwtPjI+WCW2Z8281Vlq9zHJUcFVHlErvzF5f1ng1nGnvO ntMtK0JBqhx/Ey1/lNeO7QqmnSgDaxfILPaYE62gSckfr7wvWzEckGnlnzBZgjmqaA 49Xk48MJ58qF6Aqi3k5ZGvf3hn/il3Fc/z3SSwSxITul+w2zwUgnwHqVIu1XEKAJaT 9MOj1u/IvL1+w== Date: Tue, 25 Jun 2024 17:43:18 -0700 From: Jakub Kicinski To: Kuniyuki Iwashima Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Rao Shoaib , Kuniyuki Iwashima , Subject: Re: [PATCH v1 net 00/11] af_unix: Fix bunch of MSG_OOB bugs and add new tests. Message-ID: <20240625174318.76c8a57d@kernel.org> In-Reply-To: <20240625013645.45034-1-kuniyu@amazon.com> References: <20240625013645.45034-1-kuniyu@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 24 Jun 2024 18:36:34 -0700 Kuniyuki Iwashima wrote: > This series rewrites the selftest for AF_UNIX MSG_OOB and fixes > bunch of bugs that AF_UNIX behaves differently compared to TCP. I like pairing the fix with the selftest, but at the same time "let's rewrite the selftest first" gives me pause. We have 40 LoC of actual changes here and 1000 LoC of test churn. I guess we'll find out on Thursday if we went too far :) > net/unix/af_unix.c | 37 +- > tools/testing/selftests/net/.gitignore | 1 - > tools/testing/selftests/net/af_unix/Makefile | 2 +- > tools/testing/selftests/net/af_unix/msg_oob.c | 734 ++++++++++++++++++ > .../selftests/net/af_unix/test_unix_oob.c | 436 ----------- > 5 files changed, 766 insertions(+), 444 deletions(-) > create mode 100644 tools/testing/selftests/net/af_unix/msg_oob.c > delete mode 100644 tools/testing/selftests/net/af_unix/test_unix_oob.c