From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, virtualization@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
venkat.x.venkatsubra@oracle.com, gia-khanh.nguyen@oracle.com
Subject: Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
Date: Wed, 26 Jun 2024 03:52:23 -0400 [thread overview]
Message-ID: <20240626035132-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEvO+hAd-JeM-LEAavZqogEhSBPQRhSQK6hPMaVyEHH7jQ@mail.gmail.com>
On Wed, Jun 26, 2024 at 09:58:32AM +0800, Jason Wang wrote:
> On Tue, Jun 25, 2024 at 4:32 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Tue, Jun 25, 2024 at 04:11:05PM +0800, Jason Wang wrote:
> > > On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > > >
> > > > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote:
> > > > > Workqueue is used to serialize those so we won't lose any change.
> > > >
> > > > So we don't need to re-read then?
> > > >
> > >
> > > We might have to re-read but I don't get why it is a problem for us.
> > >
> > > Thanks
> >
> > I don't think each ethtool command should force a full config read,
> > is what I mean. Only do it if really needed.
>
> We don't, as we will check config_pending there.
>
> Thanks
And config_pending set from an interrupt? That's fine.
But it's not what this patch does, right?
> >
> > --
> > MST
> >
prev parent reply other threads:[~2024-06-26 7:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 2:45 [PATCH V2 0/3] virtio-net: synchronize operstate with admin state on up/down Jason Wang
2024-06-24 2:45 ` [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt Jason Wang
2024-06-24 9:59 ` Michael S. Tsirkin
2024-06-25 1:27 ` Jason Wang
2024-06-25 7:11 ` Michael S. Tsirkin
2024-06-25 7:50 ` Jason Wang
2024-06-25 8:04 ` Michael S. Tsirkin
2024-06-25 8:18 ` Jason Wang
2024-06-25 8:31 ` Michael S. Tsirkin
2024-06-24 2:45 ` [PATCH V2 2/3] virtio: export virtio_config_{enable|disable}() Jason Wang
2024-06-24 2:45 ` [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down Jason Wang
2024-06-24 10:07 ` Michael S. Tsirkin
2024-06-25 1:27 ` Jason Wang
2024-06-25 7:16 ` Michael S. Tsirkin
2024-06-25 7:46 ` Jason Wang
2024-06-25 7:57 ` Michael S. Tsirkin
2024-06-25 8:11 ` Jason Wang
2024-06-25 8:32 ` Michael S. Tsirkin
2024-06-26 1:58 ` Jason Wang
2024-06-26 7:52 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626035132-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=gia-khanh.nguyen@oracle.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=venkat.x.venkatsubra@oracle.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).