From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, Alexander Duyck <alexanderduyck@fb.com>,
davem@davemloft.net, pabeni@redhat.com
Subject: Re: [net-next PATCH v2 02/15] eth: fbnic: Add scaffolding for Meta's NIC driver
Date: Wed, 26 Jun 2024 07:16:48 -0700 [thread overview]
Message-ID: <20240626071648.1fe1983d@kernel.org> (raw)
In-Reply-To: <171932614407.3072535.16320831117421799545.stgit@ahduyck-xeon-server.home.arpa>
On Tue, 25 Jun 2024 07:35:44 -0700 Alexander Duyck wrote:
> +/**
> + * fbnic_init_module - Driver Registration Routine
> + *
> + * The first routine called when the driver is loaded. All it does is
> + * register with the PCI subsystem.
> + **/
> +static int __init fbnic_init_module(void)
kdoc got more nit picky in the meantime, we need a Return: annotation
here.. or maybe make it a non-kdoc comment?
next prev parent reply other threads:[~2024-06-26 14:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 14:35 [net-next PATCH v2 00/15] eth: fbnic: Add network driver for Meta Platforms Host Network Interface Alexander Duyck
2024-06-25 14:35 ` [net-next PATCH v2 01/15] PCI: Add Meta Platforms vendor ID Alexander Duyck
2024-06-25 14:35 ` [net-next PATCH v2 02/15] eth: fbnic: Add scaffolding for Meta's NIC driver Alexander Duyck
2024-06-26 14:16 ` Jakub Kicinski [this message]
2024-06-26 15:20 ` Alexander Duyck
2024-06-25 14:35 ` [net-next PATCH v2 03/15] eth: fbnic: Allocate core device specific structures and devlink interface Alexander Duyck
2024-06-25 14:35 ` [net-next PATCH v2 04/15] eth: fbnic: Add register init to set PCIe/Ethernet device config Alexander Duyck
2024-06-25 15:01 ` Andrew Lunn
2024-06-25 16:07 ` Alexander Duyck
2024-06-25 14:35 ` [net-next PATCH v2 05/15] eth: fbnic: Add message parsing for FW messages Alexander Duyck
2024-06-25 14:35 ` [net-next PATCH v2 06/15] eth: fbnic: Add FW communication mechanism Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 07/15] eth: fbnic: Allocate a netdevice and napi vectors with queues Alexander Duyck
2024-06-25 21:18 ` Joe Damato
2024-06-25 23:13 ` Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 08/15] eth: fbnic: Implement Tx queue alloc/start/stop/free Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 09/15] eth: fbnic: Implement Rx " Alexander Duyck
2024-06-28 15:14 ` Simon Horman
2024-06-28 15:36 ` Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 10/15] eth: fbnic: Add initial messaging to notify FW of our presence Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 11/15] eth: fbnic: Add link detection Alexander Duyck
2024-06-25 15:25 ` Andrew Lunn
2024-06-25 16:29 ` Alexander Duyck
2024-06-25 17:05 ` Andrew Lunn
2024-06-25 14:36 ` [net-next PATCH v2 12/15] eth: fbnic: Add basic Tx handling Alexander Duyck
2024-06-26 14:18 ` Jakub Kicinski
2024-06-25 14:36 ` [net-next PATCH v2 13/15] eth: fbnic: Add basic Rx handling Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 14/15] eth: fbnic: Add L2 address programming Alexander Duyck
2024-06-25 14:36 ` [net-next PATCH v2 15/15] eth: fbnic: Write the TCAM tables used for RSS control and Rx to host Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626071648.1fe1983d@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).