netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Andrew Lunn <andrew@lunn.ch>,
	nex.sw.ncis.osdt.itp.upstreaming@intel.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields
Date: Wed, 26 Jun 2024 07:54:21 -0700	[thread overview]
Message-ID: <20240626075421.1430e8d4@kernel.org> (raw)
In-Reply-To: <20240625114432.1398320-2-aleksander.lobakin@intel.com>

On Tue, 25 Jun 2024 13:44:28 +0200 Alexander Lobakin wrote:
> -		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %llx\n",
> +		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %x\n",

compiler says %lx

net/8021q/vlanproc.c: In function ‘vlandev_seq_show’:
net/8021q/vlanproc.c:241:69: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘long unsigned int’ [-Wformat=]
  241 |                    "%s  VID: %d  REORDER_HDR: %i  dev->priv_flags: %x\n",
      |                                                                    ~^
      |                                                                     |
      |                                                                     unsigned int
      |                                                                    %lx
  242 |                    vlandev->name, vlan->vlan_id,
  243 |                    (int)(vlan->flags & 1), vlandev->priv_flags);
      |                                            ~~~~~~~~~~~~~~~~~~~       
      |                                                   |
      |                                                   long unsigned int
-- 
pw-bot: cr

  parent reply	other threads:[~2024-06-26 14:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 11:44 [PATCH net-next 0/5] netdev_features: start cleaning netdev_features_t up Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields Alexander Lobakin
2024-06-26 14:51   ` Jakub Kicinski
2024-06-27  9:50     ` Alexander Lobakin
2024-06-27 19:55       ` Jakub Kicinski
2024-06-28 10:37         ` Alexander Lobakin
2024-06-28 16:03         ` Edward Cree
2024-06-29  1:59           ` Jakub Kicinski
2024-07-02 16:08             ` Edward Cree
2024-06-26 14:54   ` Jakub Kicinski [this message]
2024-06-27  9:48     ` Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 2/5] netdev_features: remove unused __UNUSED_NETIF_F_1 Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 3/5] netdev_features: convert NETIF_F_LLTX to dev->lltx Alexander Lobakin
2024-06-25 14:00   ` Eric Dumazet
2024-06-26  8:52     ` Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 4/5] netdev_features: convert NETIF_F_NETNS_LOCAL to dev->netns_local Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 5/5] netdev_features: convert NETIF_F_FCOE_MTU to dev->fcoe_mtu Alexander Lobakin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240626075421.1430e8d4@kernel.org \
    --to=kuba@kernel.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
    --cc=pabeni@redhat.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).