From: Jakub Kicinski <kuba@kernel.org>
To: Jon Kohler <jon@nutanix.com>
Cc: Christian Benvenuti <benve@cisco.com>,
Satish Kharat <satishkh@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] enic: add ethtool get_channel support
Date: Wed, 26 Jun 2024 19:10:14 -0700 [thread overview]
Message-ID: <20240626191014.25b9b352@kernel.org> (raw)
In-Reply-To: <20240626005339.649168-1-jon@nutanix.com>
On Tue, 25 Jun 2024 17:53:38 -0700 Jon Kohler wrote:
> + channels->combined_count = 1;
clang complains about the lack of break or fallthrough here,
as annoying and pointless of a warning as it is :(
drivers/net/ethernet/cisco/enic/enic_ethtool.c:627:2: note: insert 'break;' to avoid fall-through
627 | default:
| ^
| break;
> + default:
> + break;
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-27 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 0:53 [PATCH net-next v3] enic: add ethtool get_channel support Jon Kohler
2024-06-27 2:10 ` Jakub Kicinski [this message]
2024-06-27 20:10 ` Jon Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626191014.25b9b352@kernel.org \
--to=kuba@kernel.org \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).