From: Stephen Hemminger <stephen@networkplumber.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Konstantin Taranov <kotaranov@linux.microsoft.com>,
Wei Hu <weh@microsoft.com>,
"sharmaajay@microsoft.com" <sharmaajay@microsoft.com>,
Long Li <longli@microsoft.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Set correct device into ib
Date: Thu, 27 Jun 2024 08:27:36 -0700 [thread overview]
Message-ID: <20240627082736.34ded856@hermes.local> (raw)
In-Reply-To: <PAXPR83MB05596705E21C2869A4FA6919B4D72@PAXPR83MB0559.EURPRD83.prod.outlook.com>
On Thu, 27 Jun 2024 10:44:02 +0000
Konstantin Taranov <kotaranov@microsoft.com> wrote:
> >
> > I don't want to be first and only one driver that uses this flag outside of
> > netdev. So please add new function to netdev part of mana driver to return
> > right ndev.
> >
> > Something like that:
> > struct net_device *mana__get_netdev(struct mana_context *mc) {
> > struct net_device *ndev;
> >
> > if (mana_ndev_is_slave(mc->ports[0]))
> > ndev = netdev_master_upper_dev_get_rcu(mc->ports[0]);
> > else
> > ndev = mc->ports[0];
> >
> > return ndev;
> > }
> >
> > And get Acks from netdev maintainers (Jakub, David, Eric, Paolo).
>
> Ok. Makes sense.
> I will just call it more exact:
> mana_get_not_slave_netdev_rcu()
Please don't introduce more usages of the term "slave".
Better to stick to VF.
next prev parent reply other threads:[~2024-06-27 15:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1719311307-7920-1-git-send-email-kotaranov@linux.microsoft.com>
2024-06-26 5:47 ` [PATCH rdma-next 1/1] RDMA/mana_ib: Set correct device into ib Leon Romanovsky
2024-06-26 9:05 ` Konstantin Taranov
2024-06-26 12:11 ` Leon Romanovsky
2024-06-26 15:27 ` Stephen Hemminger
2024-06-26 15:33 ` Leon Romanovsky
2024-06-26 16:10 ` Stephen Hemminger
2024-06-26 18:19 ` Konstantin Taranov
2024-06-26 18:29 ` Haiyang Zhang
2024-06-27 9:57 ` Leon Romanovsky
2024-06-27 10:44 ` Konstantin Taranov
2024-06-27 15:27 ` Stephen Hemminger [this message]
2024-11-21 0:03 ` Long Li
2024-11-25 15:56 ` Parav Pandit
2024-11-25 20:10 ` Leon Romanovsky
2024-11-27 19:46 ` [EXTERNAL] " Long Li
2024-11-28 9:39 ` Leon Romanovsky
2024-12-03 18:32 ` Long Li
2025-02-07 21:39 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627082736.34ded856@hermes.local \
--to=stephen@networkplumber.org \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sharmaajay@microsoft.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).