From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D92198A31 for ; Thu, 27 Jun 2024 15:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719502069; cv=none; b=SOllvXswVTYJ5fxxTCYXr/R3D396H41EBjnW7QELmaWxGO4RYX72aYBYz3u05GqJZrk09xQrPfYqFkqyYtZQcT7xE9o2abguZuBxOqvckx2eM7kbXCKiVQzfoEiBZ9bWA8oxE+5qW9XB8htw3EFCOyXp5+MNByV2u6pDn4K/+Xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719502069; c=relaxed/simple; bh=MCcKh+Te3MluMt/hBoNCtQN0lNaNkAplmbKTwZRlgkE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZDo67Wure3U7jje+LfEotG76bkEhHc1y9SVakUfSffB6XqYxwcSjTVi3csvPxoSYe+BLq0tkS6idFponComkJUS3xNCLFU393L2tztcpd6pmz8yOp+DjpSoQfyQ2hs0/S7+O/3BPK2+vJ+LjjME0ndkPPnA4rZDECvrFLEf60C8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=HDkrenRc; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="HDkrenRc" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2c5362c7c0bso5906106a91.1 for ; Thu, 27 Jun 2024 08:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719502067; x=1720106867; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9itoRg4hkzQHK7gOStndwazEBaHhxM4RVlJuAwijkSU=; b=HDkrenRcNPZMhMx/GWFDcT9rfC+ph9jmU+aHI4xpM8nRwtfPCtdgqn0MsVCeakEKkn uBEJnTUfM/dTbSFnHUdS8Bh6Tf4ItTabqBESpTUeIuH0TdvmMhXn34GhPHZXYJMjjCk2 LMJp/IKxnWtUCOx1ks1lUq+4390u7vUigOuZfq6/GTlQxKJWzU+UgGXiV3GXXCz1gYDm uHLsSLXwmV8g5fNlWPc0QzFV5VdepDTlQK9YWEwo1D6X0Pei61AmsmCZofRczf7RUUdC ixXVydiX40J0mTz40edcK4jWlhpQIT0nBp1CedsPb6E46m3NpEcj3FXDQAsQlQ5KBYg0 svjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719502067; x=1720106867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9itoRg4hkzQHK7gOStndwazEBaHhxM4RVlJuAwijkSU=; b=wPD9cJsy7WgDHh/yHpJihkhim0Mx6SywBYXGSlSG5mzgAeB8Q68CwS+W4n9pJn9noL xexG4W/VPByg+rDjylXJFgvCBPsOkz9p0R4nkQ8uE3HgG9BhBd7176ZLTGh7FMdFIDxl AEw7YJWCDeKC6ca9FJc5VOTgap0Cvy3iYG3lDGh/RmGBNQAdnQ9D0PCE/ny/WbXOC7hz VXHsUGKs4qG1NVCguctkBaN+bCHawZdO9Pl32hCjXeBSNKqxWimBK6CX7ssozeRQoQZ+ jeM677+faJUyF7fu9Q0UFJANIDn38rFxGh7xzM1fv5DY0GjXyq4nprj4m0xO8xBb8FP2 uEQQ== X-Forwarded-Encrypted: i=1; AJvYcCVGHDzjFYoP/NIoJur83kWqtXcVuVn+FUINQzbiU6XJAVfec97ND4gLmMB6OjfQwbcBPw5dLfipeeJdPeo17sJAspFuxLvU X-Gm-Message-State: AOJu0YzGbpRfODnLAluze1jQNLDKMJgAOflUUH3J74+yUO0gqp226UAk j5J5ozm5DAr2ghtJWPcDBWN6JcWpZDHWJU/6JtzsTxiBi96fDSmv8rnCZno8zf8= X-Google-Smtp-Source: AGHT+IEke9+TTjnHY0SqzOq3H8948zV45u3a0yDIPz5OgX6h8hhkaHXP8IkjUcvJX+T+68y/MGmHww== X-Received: by 2002:a17:90a:d084:b0:2c7:35f6:87e5 with SMTP id 98e67ed59e1d1-2c8612c6c27mr12214771a91.5.1719502067064; Thu, 27 Jun 2024 08:27:47 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c906f38b11sm1344533a91.28.2024.06.27.08.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 08:27:46 -0700 (PDT) Date: Thu, 27 Jun 2024 08:27:36 -0700 From: Stephen Hemminger To: Konstantin Taranov Cc: Leon Romanovsky , Haiyang Zhang , Konstantin Taranov , Wei Hu , "sharmaajay@microsoft.com" , Long Li , "jgg@ziepe.ca" , "linux-rdma@vger.kernel.org" , linux-netdev Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Set correct device into ib Message-ID: <20240627082736.34ded856@hermes.local> In-Reply-To: References: <1719311307-7920-1-git-send-email-kotaranov@linux.microsoft.com> <20240626054748.GN29266@unreal> <20240626121118.GP29266@unreal> <20240626082731.70d064bb@hermes.local> <20240626153354.GQ29266@unreal> <20240626091028.1948b223@hermes.local> <20240627095705.GS29266@unreal> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 27 Jun 2024 10:44:02 +0000 Konstantin Taranov wrote: > > > > I don't want to be first and only one driver that uses this flag outside of > > netdev. So please add new function to netdev part of mana driver to return > > right ndev. > > > > Something like that: > > struct net_device *mana__get_netdev(struct mana_context *mc) { > > struct net_device *ndev; > > > > if (mana_ndev_is_slave(mc->ports[0])) > > ndev = netdev_master_upper_dev_get_rcu(mc->ports[0]); > > else > > ndev = mc->ports[0]; > > > > return ndev; > > } > > > > And get Acks from netdev maintainers (Jakub, David, Eric, Paolo). > > Ok. Makes sense. > I will just call it more exact: > mana_get_not_slave_netdev_rcu() Please don't introduce more usages of the term "slave". Better to stick to VF.