From: Jakub Kicinski <kuba@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, Milena Olech <milena.olech@intel.com>,
<richardcochran@gmail.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Karol Kolacinski <karol.kolacinski@intel.com>,
Simon Horman <horms@kernel.org>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net 1/4] ice: Fix improper extts handling
Date: Thu, 27 Jun 2024 16:16:45 -0700 [thread overview]
Message-ID: <20240627161645.6c92d1ed@kernel.org> (raw)
In-Reply-To: <ZnwZQMe1outhbqPG@boxer>
On Wed, 26 Jun 2024 15:36:00 +0200 Maciej Fijalkowski wrote:
> > +
> > + for (i = 0; i < pf->ptp.info.n_ext_ts; i++) {
> > + if (pf->ptp.extts_channels[i].ena) {
> > + ice_ptp_cfg_extts(pf, i, &pf->ptp.extts_channels[i],
> > + false);
> > + }
> > + }
>
> nit: you don't need braces for single line statements.
>
> maybe you could rewrite it as below but i'm not sure if it's more
> readable. up to you.
>
> int i, cnt = pf->ptp.info.n_ext_ts;
>
> for (i = 0; i < cnt && pf->ptp.extts_channels[i].ena; i++)
> ice_ptp_cfg_extts(pf, i, &pf->ptp.extts_channels[i], false);
not sure this is functionally equivalent, but agreed on the point about
the braces.
Also, FWIW, the commit message doesn't read super well..
next prev parent reply other threads:[~2024-06-27 23:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 17:02 [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2024-06-25 (ice) Tony Nguyen
2024-06-25 17:02 ` [PATCH net 1/4] ice: Fix improper extts handling Tony Nguyen
2024-06-26 13:36 ` Maciej Fijalkowski
2024-06-27 23:16 ` Jakub Kicinski [this message]
2024-06-27 23:15 ` Jakub Kicinski
2024-06-25 17:02 ` [PATCH net 2/4] ice: Don't process extts if PTP is disabled Tony Nguyen
2024-06-25 17:57 ` Nelson, Shannon
2024-06-27 10:42 ` Kolacinski, Karol
2024-07-08 21:25 ` Keller, Jacob E
2024-07-08 21:24 ` Keller, Jacob E
2024-06-25 17:02 ` [PATCH net 3/4] ice: Reject pin requests with unsupported flags Tony Nguyen
2024-06-25 17:02 ` [PATCH net 4/4] ice: use proper macro for testing bit Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627161645.6c92d1ed@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).