From: Simon Horman <horms@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Marcin Szycik <marcin.szycik@linux.intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
michal.swiatkowski@linux.intel.com
Subject: Re: [PATCH iwl-next 5/6] ice: Optimize switch recipe creation
Date: Fri, 28 Jun 2024 19:25:09 +0100 [thread overview]
Message-ID: <20240628182509.GF837606@kernel.org> (raw)
In-Reply-To: <5328363b-1ff0-439e-94f7-c6d3ca6039cd@intel.com>
On Fri, Jun 28, 2024 at 03:56:55PM +0200, Przemek Kitszel wrote:
> On 6/28/24 14:44, Simon Horman wrote:
> > On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote:
...
> > I appreciate the detailed description above, it is very helpful.
> > After a number of readings of this patch - it is complex -
> > I was unable to find anything wrong. And I do like both the simplification
> > and better hw utilisation that this patch (set) brings.
> >
> > So from that perspective:
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > I would say, however, that it might have been easier to review
> > if somehow this patch was broken up into smaller pieces.
> > I appreciate that, in a sense, that is what the other patches
> > of this series do. But nonetheless... it is complex.
> >
> > ...
>
> all of the "bugs" that I have internally found for this patch were
> addressed by commit msg or comment changes ;)
> what about you reviewing also patch 7 from v3 of this series?
Right, sorry about accidently reviewing an old version of the patchset.
I will look at 7 from v3.
next prev parent reply other threads:[~2024-06-28 18:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:11 [PATCH iwl-next 0/6] Switch API optimizations Marcin Szycik
2024-06-18 14:11 ` [PATCH iwl-next 1/6] ice: Remove unused struct ice_prot_lkup_ext members Marcin Szycik
2024-06-28 12:40 ` Simon Horman
2024-06-18 14:11 ` [PATCH iwl-next 2/6] ice: Remove reading all recipes before adding a new one Marcin Szycik
2024-06-28 12:41 ` Simon Horman
2024-06-18 14:11 ` [PATCH iwl-next 3/6] ice: Simplify bitmap setting in adding recipe Marcin Szycik
2024-06-19 14:34 ` [Intel-wired-lan] " Alexander Lobakin
2024-06-18 14:11 ` [PATCH iwl-next 4/6] ice: remove unused recipe bookkeeping data Marcin Szycik
2024-06-28 12:41 ` Simon Horman
2024-06-18 14:11 ` [PATCH iwl-next 5/6] ice: Optimize switch recipe creation Marcin Szycik
2024-06-28 12:44 ` Simon Horman
2024-06-28 13:39 ` [Intel-wired-lan] " Marcin Szycik
2024-06-28 18:22 ` Simon Horman
2024-06-28 13:56 ` Przemek Kitszel
2024-06-28 18:25 ` Simon Horman [this message]
2024-06-18 14:11 ` [PATCH iwl-next 6/6] ice: Remove unused members from switch API Marcin Szycik
2024-06-28 12:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628182509.GF837606@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).