From: Simon Horman <horms@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Dima Ruinskiy <dima.ruinskiy@intel.com>,
sasha.neftin@intel.com,
Vitaly Lifshits <vitaly.lifshits@intel.com>
Subject: Re: [PATCH net] e1000e: Fix S0ix residency on corporate systems
Date: Mon, 1 Jul 2024 12:04:54 +0100 [thread overview]
Message-ID: <20240701110454.GW17134@kernel.org> (raw)
In-Reply-To: <20240628201754.2744221-1-anthony.l.nguyen@intel.com>
On Fri, Jun 28, 2024 at 01:17:53PM -0700, Tony Nguyen wrote:
> From: Dima Ruinskiy <dima.ruinskiy@intel.com>
>
> On vPro systems, the configuration of the I219-LM to achieve power
> gating and S0ix residency is split between the driver and the CSME FW.
> It was discovered that in some scenarios, where the network cable is
> connected and then disconnected, S0ix residency is not always reached.
> This was root-caused to a subset of I219-LM register writes that are not
> performed by the CSME FW. Therefore, the driver should perform these
> register writes on corporate setups, regardless of the CSME FW state.
>
> This was discovered on Meteor Lake systems; however it is likely to
> appear on other platforms as well.
>
> Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=218589
> Signed-off-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-07-01 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 20:17 [PATCH net] e1000e: Fix S0ix residency on corporate systems Tony Nguyen
2024-07-01 11:04 ` Simon Horman [this message]
2024-07-02 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701110454.GW17134@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).