From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646A2537E7 for ; Mon, 1 Jul 2024 11:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719831898; cv=none; b=Q52u1/C9U6ZLNkS3K6I5+YkP5DS7X6EAcx9hXjE8nRadr7/lC3KeL6/GyuEj6kSdM5FImQ3XNuJ+Hg/ewUg8VcVmLBr+swTTFLPdXc3hEQ3fp2HccVBrhEzaM9htTEs0m/4IUxUumNxBFKSJupAKBPARiG5yHr9XjJ8IMJoF37w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719831898; c=relaxed/simple; bh=Tdu35zkCaj9dNT3Y2EyFcFFG7H5luFNq1c0E1jFjfz8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oI5AT4+QhDOQvKB7Cjz4+Ir4eBfq19s5rAnSKkU19QTcL/LmXta1CqiBd8HufUQb05M6JLFgH/wX3d6FbrzKk85EsopcbA1AmeoibVAHWvV5rLuS/rgtOLJxgQ/ajl9o3/jW/92CDTGTP8H+lGQRoUCa3N0qFhKfaB4cPT2L/mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fzPW+pHs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fzPW+pHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E9ECC116B1; Mon, 1 Jul 2024 11:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719831897; bh=Tdu35zkCaj9dNT3Y2EyFcFFG7H5luFNq1c0E1jFjfz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzPW+pHsNQp8Bth8QFvod4emnGot+0hwXOpFVwZvJc7p4SC09ZISmjCbeWwv2qobj YOXs1RHdbidVhKVjW/5Z0SX0hxD1Vze/U/rbyQSGxN88p2RW9MoAFr5CHPgUe1z41H WF2uzTFo9crnSq5TKzsYevnZ1Hx4q9w6fM7iLffdxXmzHHWlNnIJCmqfrdMA4lTGdc EIn5GZiHJA6jlOd7AFEUAbN0wQOujYDr5AaZJzdTT0SoXjtKvb21KGEAA1yXK1m/+B nAn2owQlkTAPLwSn7Go5S0wk5h2DYssQcnU13FxwgwvCG1jcgPP0j0IFT2Uq3qHOYO 8tXaPM/dLLJfA== Date: Mon, 1 Jul 2024 12:04:54 +0100 From: Simon Horman To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, Dima Ruinskiy , sasha.neftin@intel.com, Vitaly Lifshits Subject: Re: [PATCH net] e1000e: Fix S0ix residency on corporate systems Message-ID: <20240701110454.GW17134@kernel.org> References: <20240628201754.2744221-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628201754.2744221-1-anthony.l.nguyen@intel.com> On Fri, Jun 28, 2024 at 01:17:53PM -0700, Tony Nguyen wrote: > From: Dima Ruinskiy > > On vPro systems, the configuration of the I219-LM to achieve power > gating and S0ix residency is split between the driver and the CSME FW. > It was discovered that in some scenarios, where the network cable is > connected and then disconnected, S0ix residency is not always reached. > This was root-caused to a subset of I219-LM register writes that are not > performed by the CSME FW. Therefore, the driver should perform these > register writes on corporate setups, regardless of the CSME FW state. > > This was discovered on Meteor Lake systems; however it is likely to > appear on other platforms as well. > > Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218589 > Signed-off-by: Dima Ruinskiy > Signed-off-by: Vitaly Lifshits > Signed-off-by: Tony Nguyen Reviewed-by: Simon Horman