From: Liu Jing <liujing@cmss.chinamobile.com>
To: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Liu Jing <liujing@cmss.chinamobile.com>
Subject: [PATCH] net/ulp: remove unnecessary assignment in tcp_register_ulp
Date: Mon, 1 Jul 2024 19:42:40 +0800 [thread overview]
Message-ID: <20240701114240.7020-1-liujing@cmss.chinamobile.com> (raw)
in the tcp_register_ulp function, the initialized value of 'ret' is unused,
because it will be assigned a value by the -EEXIST.thus remove it.
Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>
---
net/ipv4/tcp_ulp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_ulp.c b/net/ipv4/tcp_ulp.c
index 2aa442128630..d11bde357e48 100644
--- a/net/ipv4/tcp_ulp.c
+++ b/net/ipv4/tcp_ulp.c
@@ -58,7 +58,7 @@ static const struct tcp_ulp_ops *__tcp_ulp_find_autoload(const char *name)
*/
int tcp_register_ulp(struct tcp_ulp_ops *ulp)
{
- int ret = 0;
+ int ret;
spin_lock(&tcp_ulp_list_lock);
if (tcp_ulp_find(ulp->name))
--
2.33.0
next reply other threads:[~2024-07-01 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 11:42 Liu Jing [this message]
2024-07-01 12:52 ` [PATCH] net/ulp: remove unnecessary assignment in tcp_register_ulp Michal Kubiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701114240.7020-1-liujing@cmss.chinamobile.com \
--to=liujing@cmss.chinamobile.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox