Re: [PATCH iwl-next 3/7] ice: Align E810T GPIO to other products

[Simon Horman <horms@kernel.org>]

On Thu, Jun 27, 2024 at 05:09:27PM +0200, Karol Kolacinski wrote:
> Instead of having separate PTP GPIO implementation for E810T, use
> existing one from all other products.
> 
> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>

...

> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c

...

> @@ -72,242 +78,99 @@ static int ice_ptp_find_pin_idx(struct ice_pf *pf, enum ptp_pin_function func,
>  
>  	return -1;
>  }
> -

nit: I think this blank line should stay

>  /**
> - * ice_get_sma_config_e810t
> - * @hw: pointer to the hw struct
> - * @ptp_pins: pointer to the ptp_pin_desc struture
> - *
> - * Read the configuration of the SMA control logic and put it into the
> - * ptp_pin_desc structure
> + * ice_ptp_update_sma_data - update SMA pins data according to pins setup
> + * @pf: Board private structure
> + * @sma_pins: parsed SMA pins status
> + * @data: SMA data to update
>   */
> -static int
> -ice_get_sma_config_e810t(struct ice_hw *hw, struct ptp_pin_desc *ptp_pins)
> +static void ice_ptp_update_sma_data(struct ice_pf *pf, uint sma_pins[],
> +				    u8 *data)

...