From: Jakub Kicinski <kuba@kernel.org>
To: 'Simon Horman' <horms@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Ding Tianhong <dingtianhong@huawei.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Sam Sun <samsun1006219@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v5] bonding: Fix out-of-bounds read in bond_option_arp_ip_targets_set()
Date: Mon, 1 Jul 2024 14:32:47 -0700 [thread overview]
Message-ID: <20240701143247.07bc17c9@kernel.org> (raw)
In-Reply-To: <20240630-bond-oob-v5-1-7d7996e0a077@kernel.org>
On Sun, 30 Jun 2024 14:20:55 +0100 'Simon Horman' wrote:
> + if (!(strlen(newval->string)) ||
The extra brackets made me look, this really feels like it wants to be
written as:
if (!newval->string[0] ||
or:
if (strlen(newval->string) < 1 ||
next prev parent reply other threads:[~2024-07-01 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 13:20 [PATCH net v5] bonding: Fix out-of-bounds read in bond_option_arp_ip_targets_set() 'Simon Horman'
2024-06-30 18:20 ` Jay Vosburgh
2024-07-01 0:57 ` Hangbin Liu
2024-07-01 21:32 ` Jakub Kicinski [this message]
2024-07-01 23:07 ` Jay Vosburgh
2024-07-02 2:59 ` Jakub Kicinski
2024-07-02 13:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701143247.07bc17c9@kernel.org \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samsun1006219@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).