* [PATCH] selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params)
@ 2024-07-01 11:32 Liu Jing
2024-07-02 3:03 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Liu Jing @ 2024-07-01 11:32 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, shuah
Cc: netdev, linux-kselftest, linux-kernel, Liu Jing
In the TEST_F(epoll_busy_poll, test_get_params), the initialized value of 'ret' is unused,
because it will be assigned by the ioctl.thus remove it.
Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>
---
tools/testing/selftests/net/epoll_busy_poll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/epoll_busy_poll.c b/tools/testing/selftests/net/epoll_busy_poll.c
index 16e457c2f877..652b0957b6c5 100644
--- a/tools/testing/selftests/net/epoll_busy_poll.c
+++ b/tools/testing/selftests/net/epoll_busy_poll.c
@@ -130,7 +130,7 @@ TEST_F(epoll_busy_poll, test_get_params)
* the default should be default and all fields should be zero'd by the
* kernel, so set params fields to garbage to test this.
*/
- int ret = 0;
+ int ret;
self->params.busy_poll_usecs = 0xff;
self->params.busy_poll_budget = 0xff;
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params)
2024-07-01 11:32 [PATCH] selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params) Liu Jing
@ 2024-07-02 3:03 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2024-07-02 3:03 UTC (permalink / raw)
To: Liu Jing
Cc: davem, edumazet, pabeni, shuah, netdev, linux-kselftest,
linux-kernel
On Mon, 1 Jul 2024 19:32:51 +0800 Liu Jing wrote:
> In the TEST_F(epoll_busy_poll, test_get_params), the initialized value of 'ret' is unused,
> because it will be assigned by the ioctl.thus remove it.
I don't think this is worth the noise, please don't send such changes
to networking.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-02 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 11:32 [PATCH] selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params) Liu Jing
2024-07-02 3:03 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).