From: Jakub Kicinski <kuba@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH-next v1] r8152: Convert tasklet API to new bottom half workqueue mechanism
Date: Tue, 2 Jul 2024 18:42:20 -0700 [thread overview]
Message-ID: <20240702184220.306d8085@kernel.org> (raw)
In-Reply-To: <20240701100329.93531-1-linux.amoon@gmail.com>
On Mon, 1 Jul 2024 15:33:27 +0530 Anand Moon wrote:
> Migrate tasklet APIs to the new bottom half workqueue mechanism. It
> replaces all occurrences of tasklet usage with the appropriate workqueue
> APIs throughout the alteon driver. This transition ensures compatibility
> with the latest design and enhances performance
alteon ?
> - tasklet_enable(&tp->tx_tl);
> + enable_and_queue_work(system_bh_wq, &tp->tx_work);
This is not obviously correct. Please explain why in the commit message
if you're sure this is right.
--
pw-bot: cr
next prev parent reply other threads:[~2024-07-03 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 10:03 [PATCH-next v1] r8152: Convert tasklet API to new bottom half workqueue mechanism Anand Moon
2024-07-03 1:42 ` Jakub Kicinski [this message]
2024-07-03 3:47 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702184220.306d8085@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).