From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10BF917DE0E for ; Wed, 3 Jul 2024 13:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720014416; cv=none; b=fL40HKwDDEG+dl5kFkxA5kapn+6kEXRnNZm7edaHUgDM57t4ffHhvhP7et5DiQRFiloinu4Wyv80ItJ0NVGf4Lfgy04YXjEettzCvLa3kX7tYxc7X2N4PjLsair6nvE72TW2V7Bfb2FvoSfPId61fHHXL22QdoZk4QILr273qmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720014416; c=relaxed/simple; bh=OHkW+z2KYh30J4aj3T1zTKjFAOgZWX9k3A5e2X0IPCw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Drvb3yN4EogJBIfrJVP18nolC8x5ArjEHACIYXLzzjgDr6ePg0vEbDROu4uxYEktwPR5yoOY5gt77sBv9Y92kwx33MpVe0K74QG0IHu5fNdgeoqINYTAea9VPR/3T41K86LQ8ZJadeOS84f6mrJtBMU37XemaljWRtDethvg8so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qhZqQnIp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qhZqQnIp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A8BFC2BD10; Wed, 3 Jul 2024 13:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720014415; bh=OHkW+z2KYh30J4aj3T1zTKjFAOgZWX9k3A5e2X0IPCw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qhZqQnIpnrDkFobig/z/zs7SSNPguzokSsmEU2ica/0/fJZsGwgOsOUk55RH4EZyI aaBr34Hr0X87mPyjoxoXzq2OnTa8jO+T2XeK0gTxaUUToc2av03eP9Xq6Z9fB0Q3II jiLAy+gAuu+ChMcV0a10DJbS17csFyHS8A0MsQHuoKH/GxdG7mYMtwRCAYZ0SrSw8n EAnZgchTnJ5N+rpL8g84L8aaPk4I/L7GVMBi8SpXEBrxxAbRoeavKmrsaO/1gNUY3v piQgTx6KyY/wYCtvv3G9xiqUc4fyl3e3OdoJmndr6cn9vcIShU0M7X8SaJYpe7vHl8 f5bKd9ozl+8ew== Date: Wed, 3 Jul 2024 06:46:54 -0700 From: Jakub Kicinski To: Pavan Chebbi Cc: Edward Cree , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, michael.chan@broadcom.com Subject: Re: [PATCH net-next 04/11] eth: bnxt: move from .set_rxfh to .create_rxfh_context and friends Message-ID: <20240703064654.21d67f36@kernel.org> In-Reply-To: References: <20240702234757.4188344-1-kuba@kernel.org> <20240702234757.4188344-6-kuba@kernel.org> <575edb3a-3c52-0bcf-4c19-b627dc99d2e5@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Jul 2024 18:19:18 +0530 Pavan Chebbi wrote: > > has any opportunity to say ENOMEM, or whether the driver needs to > > validate against the hardware limit itself. Hopefully Pavan (CCed) > > can elaborate. > > Because the driver is not aware of the hardware limit, and the limit > is dynamic, we can rely on FW to know if the resource request we made > was honored (there is no direct ENOMEM mechanism) > The driver already does this when we make a runtime check for > resources using bnxt_rfs_capable() when an RSS ctx is being created. > But for this version of the driver, I would prefer to keep a limit > because we have some FW improvements coming in, in the area of > resource management. > Though removing the limit may not break anything, I'd prefer to have > it removed once a FW with improvements (indicated by a query > flag/caps) is available. I like keeping the limit too, FWIW, it'd be great to give this info to user space in due course to let it make more informed decisions.