From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Simon Horman" <horms@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Marek Behún" <kabel@kernel.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
mwojtas@chromium.org, "Nathan Chancellor" <nathan@kernel.org>,
"Antoine Tenart" <atenart@kernel.org>,
"Marc Kleine-Budde" <mkl@pengutronix.de>
Subject: Re: [PATCH net-next v14 12/13] net: ethtool: strset: Allow querying phy stats by index
Date: Wed, 3 Jul 2024 12:12:37 -0700 [thread overview]
Message-ID: <20240703121237.3f8b9125@kernel.org> (raw)
In-Reply-To: <20240703085515.25dab47c@fedora-2.home>
On Wed, 3 Jul 2024 08:55:15 +0200 Maxime Chevallier wrote:
> > Elsewhere in this function it is assumed that info may be NULL.
> > But here it is dereferenced unconditionally.
>
> Hmm in almst all netlink commands we do dereference the genl_info *info
> pointer without checks.
>
> I've looked into net/netlink/genetlink.c to backtrack call-sites and it
> looks to be that indeed info can't be NULL (either populated from
> genl_start() or genl_family_rcv_msg_doit(). Maybe Jakub can confirm
> this ?
>
> If what I say above is correct, I can include a small patch to remove
> the un-necessary check that makes smatch think the genl_info pointer can
> be NULL.
The info used to be null during dumps, but I think we fixed that in
f946270d05c2 ("ethtool: netlink: always pass genl_info to .prepare_data")
Perhaps I should have cleaned up existing code :S
next prev parent reply other threads:[~2024-07-03 19:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 13:17 [PATCH net-next v13 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 01/13] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 04/13] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 05/13] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 06/13] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 07/13] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 08/13] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 09/13] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 10/13] net: ethtool: pse-pd: " Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 11/13] net: ethtool: cable-test: " Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 12/13] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-07-02 10:54 ` Simon Horman
2024-07-03 6:55 ` Maxime Chevallier
2024-07-03 19:12 ` Jakub Kicinski [this message]
2024-07-03 20:18 ` Simon Horman
2024-07-01 13:17 ` [PATCH net-next v14 13/13] Documentation: networking: document phy_link_topology Maxime Chevallier
2024-07-01 13:23 ` [PATCH net-next v13 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703121237.3f8b9125@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=mwojtas@chromium.org \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).