From: Simon Horman <horms@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us,
rkannoth@marvell.com, jdamato@fastly.com, pkshih@realtek.com,
larry.chiu@realtek.com
Subject: Re: [PATCH net-next v22 01/13] rtase: Add support for a pci table in this module
Date: Wed, 3 Jul 2024 18:07:23 +0100 [thread overview]
Message-ID: <20240703170723.GH598357@kernel.org> (raw)
In-Reply-To: <20240702164829.GL598357@kernel.org>
On Tue, Jul 02, 2024 at 05:48:29PM +0100, Simon Horman wrote:
> On Mon, Jul 01, 2024 at 07:53:51PM +0800, Justin Lai wrote:
> > Add support for a pci table in this module, and implement pci_driver
> > function to initialize this driver, remove this driver, or shutdown
> > this driver.
> >
> > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> > ---
> > drivers/net/ethernet/realtek/rtase/rtase.h | 338 ++++++++++
> > .../net/ethernet/realtek/rtase/rtase_main.c | 638 ++++++++++++++++++
> > 2 files changed, 976 insertions(+)
> > create mode 100755 drivers/net/ethernet/realtek/rtase/rtase.h
> > create mode 100755 drivers/net/ethernet/realtek/rtase/rtase_main.c
> >
> > diff --git a/drivers/net/ethernet/realtek/rtase/rtase.h b/drivers/net/ethernet/realtek/rtase/rtase.h
> > new file mode 100755
>
> nit: Source files should not have the execute bit(s) set.
>
> Flagged by Checkpatch.
>
> Otherwise, this patch looks good to me.
FTR:
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-07-03 17:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 11:53 [PATCH net-next v22 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-07-01 11:53 ` [PATCH net-next v22 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-07-02 16:48 ` Simon Horman
2024-07-03 17:07 ` Simon Horman [this message]
2024-07-01 11:53 ` [PATCH net-next v22 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-07-03 16:52 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 03/13] rtase: Implement the rtase_down function Justin Lai
2024-07-03 16:59 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-07-03 17:00 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 05/13] rtase: Implement hardware configuration function Justin Lai
2024-07-03 17:01 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-07-03 17:02 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 07/13] rtase: Implement a function to receive packets Justin Lai
2024-07-03 17:02 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 08/13] rtase: Implement net_device_ops Justin Lai
2024-07-03 17:03 ` Simon Horman
2024-07-03 17:04 ` Simon Horman
2024-07-01 11:53 ` [PATCH net-next v22 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-07-03 17:04 ` Simon Horman
2024-07-01 11:54 ` [PATCH net-next v22 10/13] rtase: Implement ethtool function Justin Lai
2024-07-03 17:05 ` Simon Horman
2024-07-01 11:54 ` [PATCH net-next v22 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-07-03 17:05 ` Simon Horman
2024-07-01 11:54 ` [PATCH net-next v22 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-07-03 17:06 ` Simon Horman
2024-07-01 11:54 ` [PATCH net-next v22 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
2024-07-03 17:06 ` Simon Horman
2024-07-09 12:11 ` [PATCH net-next v22 00/13] Add Realtek automotive PCIe driver Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703170723.GH598357@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).