From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Frank Wunderlich" <linux@fw-web.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, regressions@lists.linux.dev
Subject: Re: [PATCH net v3] net: dsa: mt7530: fix impossible MDIO address and issue warning
Date: Wed, 3 Jul 2024 19:13:08 -0700 [thread overview]
Message-ID: <20240703191308.3703099c@kernel.org> (raw)
In-Reply-To: <7e3fed489c0bbca84a386b1077c61589030ff4ab.1719963228.git.daniel@makrotopia.org>
On Wed, 3 Jul 2024 00:44:28 +0100 Daniel Golle wrote:
> + /* The corrected address is calculated as stated below:
> + * 0~6 -> 31
> + * 8~14 -> 7
> + * 16~22 -> 15
> + * 24~30 -> 23
> + */
> +return ((((phy_addr - MT7530_NUM_PORTS) & ~MT7530_NUM_PORTS) % PHY_MAX_ADDR) +
> + MT7530_NUM_PORTS) & (PHY_MAX_ADDR - 1);
nit: the return statement lacks indentation
but also based on the comment, isn't it:
return (round_down(phy_addr, MT7530_NUM_PORTS + 1) - 1) & (PHY_MAX_ADDR - 1);
?
--
pw-bot: cr
next prev parent reply other threads:[~2024-07-04 2:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 23:44 [PATCH net v3] net: dsa: mt7530: fix impossible MDIO address and issue warning Daniel Golle
2024-07-03 1:07 ` Andrew Lunn
2024-07-03 7:03 ` Arınç ÜNAL
2024-07-04 17:21 ` Vladimir Oltean
2024-07-04 18:19 ` Arınç ÜNAL
2024-07-04 18:52 ` Arınç ÜNAL
2024-07-04 2:13 ` Jakub Kicinski [this message]
2024-07-04 10:48 ` Daniel Golle
2024-07-04 14:16 ` Jakub Kicinski
2024-07-04 14:46 ` Florian Fainelli
2024-07-04 15:15 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703191308.3703099c@kernel.org \
--to=kuba@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).