netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Herbert <tom@herbertland.com>
To: davem@davemloft.net, kuba@kernel.org, jesse.brandeburg@intel.com,
	anthony.l.nguyen@intel.com, cai.huoqing@linux.dev,
	netdev@vger.kernel.org, felipe@sipanda.io
Cc: Tom Herbert <tom@herbertland.com>
Subject: [RFC net-next 07/10] hisilicon: Call skb_set_csum_crc32_unnecessary
Date: Wed,  3 Jul 2024 15:48:47 -0700	[thread overview]
Message-ID: <20240703224850.1226697-8-tom@herbertland.com> (raw)
In-Reply-To: <20240703224850.1226697-1-tom@herbertland.com>

When a validated offload CRC for SCTP is detected call
skb_set_csum_crc32_unnessary instead of setting
CHECKSUM_UNNECESSARY

Signed-off-by: Tom Herbert <tom@herbertland.com>
---
 drivers/net/ethernet/hisilicon/hns/hns_enet.c  |  5 ++++-
 .../net/ethernet/hisilicon/hns3/hns3_enet.c    | 18 +++++++++++++-----
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
index fd32e15cadcb..f3e8b9cb3779 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -556,7 +556,10 @@ static void hns_nic_rx_checksum(struct hns_nic_ring_data *ring_data,
 		return;
 
 	/* now, this has to be a packet with valid RX checksum */
-	skb->ip_summed = CHECKSUM_UNNECESSARY;
+	if (l4id == HNS_RX_FLAG_L4ID_SCTP)
+		skb_set_csum_crc32_unnecessary(skb);
+	else
+		skb->ip_summed = CHECKSUM_UNNECESSARY;
 }
 
 static int hns_nic_poll_rx_skb(struct hns_nic_ring_data *ring_data,
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index a5fc0209d628..5fd98854f72d 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -3908,11 +3908,19 @@ static void hns3_rx_handle_csum(struct sk_buff *skb, u32 l234info,
 					  HNS3_RXD_L4ID_S);
 		/* Can checksum ipv4 or ipv6 + UDP/TCP/SCTP packets */
 		if ((l3_type == HNS3_L3_TYPE_IPV4 ||
-		     l3_type == HNS3_L3_TYPE_IPV6) &&
-		    (l4_type == HNS3_L4_TYPE_UDP ||
-		     l4_type == HNS3_L4_TYPE_TCP ||
-		     l4_type == HNS3_L4_TYPE_SCTP))
-			skb->ip_summed = CHECKSUM_UNNECESSARY;
+		     l3_type == HNS3_L3_TYPE_IPV6)) {
+			switch (l4_type) {
+			case HNS3_L4_TYPE_UDP:
+			case HNS3_L4_TYPE_TCP:
+				skb->ip_summed = CHECKSUM_UNNECESSARY;
+				break;
+			case HNS3_L4_TYPE_SCTP:
+				skb_set_csum_crc32_unnecessary(skb);
+				break;
+			default:
+				break;
+			}
+		}
 		break;
 	default:
 		break;
-- 
2.34.1


  parent reply	other threads:[~2024-07-03 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 22:48 [RFC net-next 00/10] crc-offload: Split RX CRC offload from csum offload Tom Herbert
2024-07-03 22:48 ` [RFC net-next 01/10] skbuff: Rename csum_not_inet to csum_is_crc32 Tom Herbert
2024-07-23 16:23   ` Mina Almasry
2024-07-03 22:48 ` [RFC net-next 02/10] skbuff: Add csum_valid_crc32 flag Tom Herbert
2024-07-03 22:48 ` [RFC net-next 03/10] sctp: Call skb_csum_crc32_unnecessary Tom Herbert
2024-07-03 22:48 ` [RFC net-next 04/10] fcoe: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 05/10] cavium_thunder: Call skb_set_csum_crc32_unnecessary Tom Herbert
2024-07-03 22:48 ` [RFC net-next 06/10] gve: " Tom Herbert
2024-07-03 22:48 ` Tom Herbert [this message]
2024-07-03 22:48 ` [RFC net-next 08/10] idpf: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 09/10] ixgbe: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 10/10] wangxun: " Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703224850.1226697-8-tom@herbertland.com \
    --to=tom@herbertland.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=cai.huoqing@linux.dev \
    --cc=davem@davemloft.net \
    --cc=felipe@sipanda.io \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).