From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Paolo Abeni <pabeni@redhat.com>, <oss-drivers@corigine.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<louis.peens@corigine.com>, <davem@davemloft.net>,
<edumazet@google.com>, <horms@kernel.org>,
<yinjun.zhang@corigine.com>, <johannes.berg@intel.com>,
<ryno.swart@corigine.com>, <ziyang.chen@corigine.com>,
<linma@zju.edu.cn>, <niklas.soderlund@corigine.com>,
Chen Ni <nichen@iscas.ac.cn>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Subject: Re: [PATCH net-next] ntp: fix size argument for kcalloc
Date: Thu, 4 Jul 2024 07:21:55 -0700 [thread overview]
Message-ID: <20240704072155.2ea340a9@kernel.org> (raw)
In-Reply-To: <2230e0ee-2bf4-4d86-b81d-1615125d3084@intel.com>
On Thu, 4 Jul 2024 12:17:39 +0200 Przemek Kitszel wrote:
> >> This patch is IMHO more a cleanup than a real fix. As such it's more
> >> suited for net-next. For the same reason I think it should not go to
> >> stable, so I'm dropping the fixes tag, too.
>
> I'm fine with targeting it at any of the trees.
>
> But I still believe it is a fix, even if a trivial one, and even if code
> "works" - it's a "wrong" code.
>
> Here I received similar feedback in a similar case:
> https://www.mail-archive.com/intel-wired-lan@osuosl.org/msg03252.html
> and I changed my mind then.
Comments, docs, and the MAINTAINERS file are special.
This is actually changing the code, and at present results in the same
binary getting generated.
next prev parent reply other threads:[~2024-07-04 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 2:56 [PATCH net-next] ntp: fix size argument for kcalloc Chen Ni
2024-07-03 9:16 ` Przemek Kitszel
2024-07-04 9:36 ` Paolo Abeni
2024-07-04 9:41 ` Paolo Abeni
2024-07-04 10:17 ` Przemek Kitszel
2024-07-04 14:21 ` Jakub Kicinski [this message]
2024-07-04 5:36 ` Louis Peens
2024-07-04 7:30 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704072155.2ea340a9@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=ryno.swart@corigine.com \
--cc=yinjun.zhang@corigine.com \
--cc=ziyang.chen@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).