* [PATCH iwl-next] ice: Fix field vector array data type
@ 2024-07-03 11:25 Marcin Szycik
2024-07-04 8:49 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Szycik @ 2024-07-03 11:25 UTC (permalink / raw)
To: intel-wired-lan
Cc: netdev, anthony.l.nguyen, Marcin Szycik, Michal Swiatkowski
Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8
instead of u16. This array contents are used solely to be later passed
to lkup_indx in struct ice_aqc_recipe_content, which is u8.
Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
---
Targeting next, as the commit to be fixed is on dev-queue.
Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
---
drivers/net/ethernet/intel/ice/ice_switch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.h b/drivers/net/ethernet/intel/ice/ice_switch.h
index 3e4af531b875..671d7a5f359f 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.h
+++ b/drivers/net/ethernet/intel/ice/ice_switch.h
@@ -226,7 +226,7 @@ struct ice_sw_recipe {
*/
struct ice_fv_word ext_words[ICE_MAX_CHAIN_WORDS];
u16 word_masks[ICE_MAX_CHAIN_WORDS];
- u16 fv_idx[ICE_MAX_CHAIN_WORDS];
+ u8 fv_idx[ICE_MAX_CHAIN_WORDS];
u16 fv_mask[ICE_MAX_CHAIN_WORDS];
/* Bit map specifying the IDs associated with this group of recipe */
--
2.45.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iwl-next] ice: Fix field vector array data type
2024-07-03 11:25 [PATCH iwl-next] ice: Fix field vector array data type Marcin Szycik
@ 2024-07-04 8:49 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-07-04 8:49 UTC (permalink / raw)
To: Marcin Szycik
Cc: intel-wired-lan, netdev, anthony.l.nguyen, Michal Swiatkowski
On Wed, Jul 03, 2024 at 01:25:02PM +0200, Marcin Szycik wrote:
> Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8
> instead of u16. This array contents are used solely to be later passed
> to lkup_indx in struct ice_aqc_recipe_content, which is u8.
>
> Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> Targeting next, as the commit to be fixed is on dev-queue.
> Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
FWIIW, this LGTM.
...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-04 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-03 11:25 [PATCH iwl-next] ice: Fix field vector array data type Marcin Szycik
2024-07-04 8:49 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).