* [PATCH v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K
@ 2024-07-04 17:26 Shengyu Qu
2024-07-05 8:35 ` Simon Horman
2024-07-06 0:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Shengyu Qu @ 2024-07-04 17:26 UTC (permalink / raw)
To: nbd, sean.wang, Mark-MC.Lee, lorenzo, davem, edumazet, kuba,
pabeni, matthias.bgg, angelogioacchino.delregno, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Shengyu Qu, Elad Yifee
MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620
supports 16384 PPE entries, but only set to 8192 entries in driver. So
incrase max entries to 16384 instead.
Signed-off-by: Elad Yifee <eladwf@gmail.com>
Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
---
Changes since V1:
- Reduced max entries from 32768 to 16384 to keep compatible with MT7620/21 devices.
- Add fixes tag
Changes since V2:
- Remove fixes tag (Thanks to Jakub)
---
drivers/net/ethernet/mediatek/mtk_ppe.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.h b/drivers/net/ethernet/mediatek/mtk_ppe.h
index 691806bca372..223f709e2704 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe.h
+++ b/drivers/net/ethernet/mediatek/mtk_ppe.h
@@ -8,7 +8,7 @@
#include <linux/bitfield.h>
#include <linux/rhashtable.h>
-#define MTK_PPE_ENTRIES_SHIFT 3
+#define MTK_PPE_ENTRIES_SHIFT 4
#define MTK_PPE_ENTRIES (1024 << MTK_PPE_ENTRIES_SHIFT)
#define MTK_PPE_HASH_MASK (MTK_PPE_ENTRIES - 1)
#define MTK_PPE_WAIT_TIMEOUT_US 1000000
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K
2024-07-04 17:26 [PATCH v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K Shengyu Qu
@ 2024-07-05 8:35 ` Simon Horman
2024-07-06 0:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-07-05 8:35 UTC (permalink / raw)
To: Shengyu Qu
Cc: nbd, sean.wang, Mark-MC.Lee, lorenzo, davem, edumazet, kuba,
pabeni, matthias.bgg, angelogioacchino.delregno, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, Elad Yifee
On Fri, Jul 05, 2024 at 01:26:26AM +0800, Shengyu Qu wrote:
> MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620
> supports 16384 PPE entries, but only set to 8192 entries in driver. So
> incrase max entries to 16384 instead.
>
> Signed-off-by: Elad Yifee <eladwf@gmail.com>
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> ---
> Changes since V1:
> - Reduced max entries from 32768 to 16384 to keep compatible with MT7620/21 devices.
> - Add fixes tag
>
> Changes since V2:
> - Remove fixes tag (Thanks to Jakub)
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K
2024-07-04 17:26 [PATCH v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K Shengyu Qu
2024-07-05 8:35 ` Simon Horman
@ 2024-07-06 0:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-07-06 0:50 UTC (permalink / raw)
To: Shengyu Qu
Cc: nbd, sean.wang, Mark-MC.Lee, lorenzo, davem, edumazet, kuba,
pabeni, matthias.bgg, angelogioacchino.delregno, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, eladwf
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 5 Jul 2024 01:26:26 +0800 you wrote:
> MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620
> supports 16384 PPE entries, but only set to 8192 entries in driver. So
> incrase max entries to 16384 instead.
>
> Signed-off-by: Elad Yifee <eladwf@gmail.com>
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
>
> [...]
Here is the summary with links:
- [v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K
https://git.kernel.org/netdev/net-next/c/ca18300e00d5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-06 0:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-04 17:26 [PATCH v3] net: ethernet: mtk_ppe: Change PPE entries number to 16K Shengyu Qu
2024-07-05 8:35 ` Simon Horman
2024-07-06 0:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).