From: kernel test robot <lkp@intel.com>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: oe-kbuild-all@lists.linux.dev, willemb@google.com,
Wojciech Drewek <wojciech.drewek@intel.com>,
dwaipayanray1@gmail.com,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
linux-kernel@vger.kernel.org,
Igor Bagnucki <igor.bagnucki@intel.com>,
joe@perches.com, edumazet@google.com, netdev@vger.kernel.org,
apw@canonical.com, lukas.bulwahn@gmail.com,
akpm@linux-foundation.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 3/6] ice: add Tx hang devlink health reporter
Date: Fri, 5 Jul 2024 08:23:53 +0800 [thread overview]
Message-ID: <202407050857.OSYEyokn-lkp@intel.com> (raw)
In-Reply-To: <20240703125922.5625-4-mateusz.polchlopek@intel.com>
Hi Mateusz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-next-queue/dev-queue]
url: https://github.com/intel-lab-lkp/linux/commits/Mateusz-Polchlopek/checkpatch-don-t-complain-on-_Generic-use/20240704-184910
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link: https://lore.kernel.org/r/20240703125922.5625-4-mateusz.polchlopek%40intel.com
patch subject: [Intel-wired-lan] [PATCH iwl-next v1 3/6] ice: add Tx hang devlink health reporter
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240705/202407050857.OSYEyokn-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240705/202407050857.OSYEyokn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407050857.OSYEyokn-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/devlink/devlink_health.c: In function 'ice_tx_hang_reporter_dump':
>> drivers/net/ethernet/intel/ice/devlink/devlink_health.c:76:43: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
76 | ice_fmsg_put_ptr(fmsg, "dma-ptr", (void *)event->tx_ring->dma);
| ^
vim +76 drivers/net/ethernet/intel/ice/devlink/devlink_health.c
60
61 static int ice_tx_hang_reporter_dump(struct devlink_health_reporter *reporter,
62 struct devlink_fmsg *fmsg, void *priv_ctx,
63 struct netlink_ext_ack *extack)
64 {
65 struct ice_tx_hang_event *event = priv_ctx;
66
67 devlink_fmsg_obj_nest_start(fmsg);
68 ICE_DEVLINK_FMSG_PUT_FIELD(fmsg, event, head);
69 ICE_DEVLINK_FMSG_PUT_FIELD(fmsg, event, intr);
70 ICE_DEVLINK_FMSG_PUT_FIELD(fmsg, event, vsi_num);
71 ICE_DEVLINK_FMSG_PUT_FIELD(fmsg, event, queue);
72 ICE_DEVLINK_FMSG_PUT_FIELD(fmsg, event, next_to_clean);
73 ICE_DEVLINK_FMSG_PUT_FIELD(fmsg, event, next_to_use);
74 devlink_fmsg_put(fmsg, "irq-mapping", event->tx_ring->q_vector->name);
75 ice_fmsg_put_ptr(fmsg, "desc-ptr", event->tx_ring->desc);
> 76 ice_fmsg_put_ptr(fmsg, "dma-ptr", (void *)event->tx_ring->dma);
77 devlink_fmsg_binary_pair_put(fmsg, "desc", event->tx_ring->desc,
78 size_mul(event->tx_ring->count,
79 sizeof(struct ice_tx_desc)));
80 devlink_fmsg_obj_nest_end(fmsg);
81
82 return 0;
83 }
84
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-07-05 0:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:59 [Intel-wired-lan] [PATCH iwl-next v1 0/6] Add support for devlink health events Mateusz Polchlopek
2024-07-03 12:59 ` [Intel-wired-lan] [PATCH iwl-next v1 1/6] checkpatch: don't complain on _Generic() use Mateusz Polchlopek
2024-07-08 12:41 ` Simon Horman
2024-07-03 12:59 ` [Intel-wired-lan] [PATCH iwl-next v1 2/6] devlink: add devlink_fmsg_put() macro Mateusz Polchlopek
2024-07-08 12:41 ` Simon Horman
2024-07-03 12:59 ` [Intel-wired-lan] [PATCH iwl-next v1 3/6] ice: add Tx hang devlink health reporter Mateusz Polchlopek
2024-07-05 0:23 ` kernel test robot [this message]
2024-07-08 12:40 ` Simon Horman
2024-07-10 13:59 ` Przemek Kitszel
2024-07-03 12:59 ` [Intel-wired-lan] [PATCH iwl-next v1 4/6] ice: print ethtool stats as part of " Mateusz Polchlopek
2024-07-08 12:41 ` Simon Horman
2024-07-03 12:59 ` [Intel-wired-lan] [PATCH iwl-next v1 5/6] ice: Add MDD logging via devlink health Mateusz Polchlopek
2024-07-08 12:42 ` Simon Horman
2024-07-03 12:59 ` [Intel-wired-lan] [PATCH iwl-next v1 6/6] ice: devlink health: dump also skb on Tx hang Mateusz Polchlopek
2024-07-08 12:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407050857.OSYEyokn-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=edumazet@google.com \
--cc=igor.bagnucki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemb@google.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).