* [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability()
@ 2024-07-05 9:53 Aleksandr Mishin
2024-07-05 11:17 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aleksandr Mishin @ 2024-07-05 9:53 UTC (permalink / raw)
To: Sunil Goutham
Cc: Aleksandr Mishin, Linu Cherian, Geetha sowjanya, Jerin Jacob,
hariprasad, Subbaraya Sundeep, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, lvc-project
In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect
data is printed to error log. 'req->sso' value is printed instead of
'req->ssow'. Looks like "copy-paste" mistake.
Fix this mistake by replacing 'req->sso' with 'req->ssow'.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 746ea74241fa ("octeontx2-af: Add RVU block LF provisioning support")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index ff78251f92d4..5f661e67ccbc 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -1643,7 +1643,7 @@ static int rvu_check_rsrc_availability(struct rvu *rvu,
if (req->ssow > block->lf.max) {
dev_err(&rvu->pdev->dev,
"Func 0x%x: Invalid SSOW req, %d > max %d\n",
- pcifunc, req->sso, block->lf.max);
+ pcifunc, req->ssow, block->lf.max);
return -EINVAL;
}
mappedlfs = rvu_get_rsrc_mapcount(pfvf, block->addr);
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability()
2024-07-05 9:53 [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability() Aleksandr Mishin
@ 2024-07-05 11:17 ` Simon Horman
2024-07-06 15:28 ` Markus Elfring
2024-07-09 11:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2024-07-05 11:17 UTC (permalink / raw)
To: Aleksandr Mishin
Cc: Sunil Goutham, Linu Cherian, Geetha sowjanya, Jerin Jacob,
hariprasad, Subbaraya Sundeep, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, lvc-project
On Fri, Jul 05, 2024 at 12:53:17PM +0300, Aleksandr Mishin wrote:
> In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect
> data is printed to error log. 'req->sso' value is printed instead of
> 'req->ssow'. Looks like "copy-paste" mistake.
>
> Fix this mistake by replacing 'req->sso' with 'req->ssow'.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 746ea74241fa ("octeontx2-af: Add RVU block LF provisioning support")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability()
2024-07-05 9:53 [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability() Aleksandr Mishin
2024-07-05 11:17 ` Simon Horman
@ 2024-07-06 15:28 ` Markus Elfring
2024-07-09 11:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2024-07-06 15:28 UTC (permalink / raw)
To: Aleksandr Mishin, netdev, lvc-project, Sunil Goutham
Cc: LKML, David S. Miller, Eric Dumazet, Geethasowjanya Akula,
Hariprasad Kelam, Jakub Kicinski, Jerin Jacob, Linu Cherian,
Paolo Abeni, Simon Horman, Subbaraya Sundeep Bhatta
> In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect
> data is printed to error log. 'req->sso' value is printed instead of
…
Another wording suggestion:
… request,
wrong data were logged. …
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability()
2024-07-05 9:53 [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability() Aleksandr Mishin
2024-07-05 11:17 ` Simon Horman
2024-07-06 15:28 ` Markus Elfring
@ 2024-07-09 11:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-07-09 11:00 UTC (permalink / raw)
To: Aleksandr Mishin
Cc: sgoutham, lcherian, gakula, jerinj, hkelam, sbhatta, davem,
edumazet, kuba, pabeni, netdev, linux-kernel, lvc-project
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 5 Jul 2024 12:53:17 +0300 you wrote:
> In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect
> data is printed to error log. 'req->sso' value is printed instead of
> 'req->ssow'. Looks like "copy-paste" mistake.
>
> Fix this mistake by replacing 'req->sso' with 'req->ssow'.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> [...]
Here is the summary with links:
- [net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability()
https://git.kernel.org/netdev/net/c/442e26af9aa8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-09 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-05 9:53 [PATCH net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability() Aleksandr Mishin
2024-07-05 11:17 ` Simon Horman
2024-07-06 15:28 ` Markus Elfring
2024-07-09 11:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).