From: Tariq Toukan <tariqt@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: <netdev@vger.kernel.org>, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH net-next V2 10/10] net/mlx5e: CT: Initialize err to 0 to avoid warning
Date: Mon, 8 Jul 2024 11:00:25 +0300 [thread overview]
Message-ID: <20240708080025.1593555-11-tariqt@nvidia.com> (raw)
In-Reply-To: <20240708080025.1593555-1-tariqt@nvidia.com>
From: Cosmin Ratiu <cratiu@nvidia.com>
It is theoretically possible to return bogus uninitialized values from
mlx5_tc_ct_entry_replace_rules, even though in practice this will never
be the case as the flow rule will be part of at least the regular ct
table or the ct nat table, if not both.
But to reduce noise, initialize err to 0.
Fixes: 49d37d05f216 ("net/mlx5: CT: Separate CT and CT-NAT tuple entries")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index b49d87a51f21..8cf8ba2622f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -1145,7 +1145,7 @@ mlx5_tc_ct_entry_replace_rules(struct mlx5_tc_ct_priv *ct_priv,
struct mlx5_ct_entry *entry,
u8 zone_restore_id)
{
- int err;
+ int err = 0;
if (mlx5_tc_ct_entry_in_ct_table(entry)) {
err = mlx5_tc_ct_entry_replace_rule(ct_priv, flow_rule, entry, false,
--
2.44.0
next prev parent reply other threads:[~2024-07-08 8:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 8:00 [PATCH net-next V2 00/10] mlx5 misc patches 2023-07-08 Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 01/10] net/mlx5: IFC updates for SF max IO EQs Tariq Toukan
2024-07-10 1:54 ` Jakub Kicinski
2024-07-10 13:08 ` Dan Jurgens
2024-07-11 0:44 ` Jakub Kicinski
2024-07-08 8:00 ` [PATCH net-next V2 02/10] net/mlx5: Set sf_eq_usage for SF max EQs Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 03/10] net/mlx5: Set default max eqs for SFs Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 04/10] net/mlx5: Use set number of max EQs Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 05/10] net/mlx5: Add support for MTPTM and MTCTR registers Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 06/10] net/mlx5: Add support for enabling PTM PCI capability Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 07/10] net/mlx5: Implement PTM cross timestamping support Tariq Toukan
2024-07-10 1:58 ` Jakub Kicinski
2024-07-08 8:00 ` [PATCH net-next V2 08/10] net/mlx5: DR, Remove definer functions from SW Steering API Tariq Toukan
2024-07-08 8:00 ` [PATCH net-next V2 09/10] net/mlx5e: SHAMPO, Add missing aggregate counter Tariq Toukan
2024-07-08 8:00 ` Tariq Toukan [this message]
2024-07-08 10:58 ` [PATCH net-next V2 00/10] mlx5 misc patches 2023-07-08 Simon Horman
2024-07-08 12:17 ` Tariq Toukan
2024-07-10 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708080025.1593555-11-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).