From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19934142E92; Mon, 8 Jul 2024 16:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720456630; cv=none; b=A/zSX/Hfz9oC4/S0FU+wXwxSnOtBcJljUIAIUaBMPC+xERiOcHvdEnpdBKQv5bSPeEdtMr+HP0KjwUTkffukjAOEY3TP76iilQXL3/fUKthENlrGTxbfcrkQO+eF5v6npg/MHgLHe8Y1BdrmmTZod8JYhWp4ecKYhvoAbmJMb3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720456630; c=relaxed/simple; bh=lJGd+nVv18omxFkLiXtuoAeQ/dT7m1C/E4pcSNjQLpM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hpSr/wDXpy4bdfPJ/8LABJ4Kryd2w4XVap1vxQgfDpqjySc/RNOhlGT/avBa3qvXkR7C+LJyOuCEslSXak5EQgkJqNrgJiQDoFnoM/De12WywcFEDQd2vQQGMRlHZNIlVW7Qrupbe46o+6KmG4qi/U0/wmU5muGEbaOtHHHPpNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cj2PdjOf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cj2PdjOf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A5BAC116B1; Mon, 8 Jul 2024 16:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720456629; bh=lJGd+nVv18omxFkLiXtuoAeQ/dT7m1C/E4pcSNjQLpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cj2PdjOfqC/V2zLlbonGQSNK7FrUxVYjTa7glx0NPUZ8w/UjO5tVv9G9kv2z/YlFi THB2lc2HBEd/Zx+4euQRPFJNSJcyHmKkUdR81UjDoLnMn9EtME7lixEnJX3JrsdKSW eK0AWaQLmXKwKQtw2EVFA0iXcoAS2fJUaCA71DpBSRsWcQIFtUbO7DV5rGD2FfiWot 8GOV6OWUTen4NxUVs98g2xOIE91QYwwFag99FoFNSz/iPQXQ5/pj/yc3zxv2vkJGUY wwcSZvyniG/BHvT03Q5+tEOiam/DPy6d6hcvwdPDQROzSuEANdYRDT7VCnLG1P5yGk k0H2VhufWVNCg== Date: Mon, 8 Jul 2024 10:37:08 -0600 From: Rob Herring To: Lorenzo Bianconi Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, rkannoth@marvell.com, sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de, horms@kernel.org Subject: Re: [PATCH v5 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Message-ID: <20240708163708.GA3371750-robh@kernel.org> References: <48dde2595c6ff497a846183b117ac9704537b78c.1720079772.git.lorenzo@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48dde2595c6ff497a846183b117ac9704537b78c.1720079772.git.lorenzo@kernel.org> On Thu, Jul 04, 2024 at 10:08:10AM +0200, Lorenzo Bianconi wrote: > Introduce device-tree binding documentation for Airoha EN7581 ethernet > mac controller. > > Signed-off-by: Lorenzo Bianconi > --- > .../bindings/net/airoha,en7581-eth.yaml | 146 ++++++++++++++++++ > 1 file changed, 146 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > new file mode 100644 > index 000000000000..f4b1f8afddd0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > @@ -0,0 +1,146 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/airoha,en7581-eth.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha EN7581 Frame Engine Ethernet controller > + > +allOf: > + - $ref: ethernet-controller.yaml# Again, to rephrase, what are you using from this binding? It does not make sense for the parent and child both to use it. > + > +maintainers: > + - Lorenzo Bianconi > + > +description: > + The frame engine ethernet controller can be found on Airoha SoCs. > + These SoCs have multi-GMAC ports. > + > +properties: > + compatible: > + enum: > + - airoha,en7581-eth > + > + reg: > + items: > + - description: Frame engine base address > + - description: QDMA0 base address > + - description: QDMA1 base address > + > + reg-names: > + items: > + - const: fe > + - const: qdma0 > + - const: qdma1 > + > + interrupts: > + items: > + - description: QDMA lan irq0 > + - description: QDMA lan irq1 > + - description: QDMA lan irq2 > + - description: QDMA lan irq3 > + - description: QDMA wan irq0 > + - description: QDMA wan irq1 > + - description: QDMA wan irq2 > + - description: QDMA wan irq3 > + - description: FE error irq > + - description: PDMA irq > + > + resets: > + maxItems: 8 > + > + reset-names: > + items: > + - const: fe > + - const: pdma > + - const: qdma > + - const: xsi-mac > + - const: hsi0-mac > + - const: hsi1-mac > + - const: hsi-mac > + - const: xfp-mac > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^mac@[1-4]$": 'ethernet' is the defined node name for users of ethernet-controller.yaml. > + type: object > + unevaluatedProperties: false > + $ref: ethernet-controller.yaml# > + description: > + Ethernet GMAC port associated to the MAC controller > + properties: > + compatible: > + const: airoha,eth-mac > + > + reg: > + minimum: 1 > + maximum: 4 > + description: GMAC port identifier > + > + required: > + - reg > + - compatible > + > +required: > + - compatible > + - reg > + - interrupts > + - resets > + - reset-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + eth0: ethernet@1fb50000 { > + compatible = "airoha,en7581-eth"; > + reg = <0 0x1fb50000 0 0x2600>, > + <0 0x1fb54000 0 0x2000>, > + <0 0x1fb56000 0 0x2000>; > + reg-names = "fe", "qdma0", "qdma1"; > + > + resets = <&scuclk 44>, > + <&scuclk 30>, > + <&scuclk 31>, > + <&scuclk 6>, > + <&scuclk 15>, > + <&scuclk 16>, > + <&scuclk 17>, > + <&scuclk 26>; > + reset-names = "fe", "pdma", "qdma", "xsi-mac", > + "hsi0-mac", "hsi1-mac", "hsi-mac", > + "xfp-mac"; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + mac1: mac@1 { > + compatible = "airoha,eth-mac"; > + reg = <1>; > + }; > + }; > + }; > -- > 2.45.2 >