netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property
@ 2024-07-04 16:17 Frank Li
  2024-07-04 16:17 ` [PATCH v3 2/2] dt-bindings: net: fsl,fman: add ptimer-handle property Frank Li
  2024-07-08 17:10 ` [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2024-07-04 16:17 UTC (permalink / raw)
  To: Madalin Bucur, Sean Anderson, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, open list:FREESCALE QORIQ DPAA FMAN DRIVER,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Add dma-coherent property to fix below warning.
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: fman@1a00000: 'dma-coherent', 'ptimer-handle' do not match any of the regexes: '^ethernet@[a-f0-9]+$', '^mdio@[a-f0-9]+$', '^muram@[a-f0-9]+$', '^phc@[a-f0-9]+$', '^port@[a-f0-9]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/net/fsl,fman.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- Fix missed one rob's comments about 'dma-coherent property' in commit
message.
Change from v1 to v2
- Fix paste wrong warning mesg.
---
 Documentation/devicetree/bindings/net/fsl,fman.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/fsl,fman.yaml b/Documentation/devicetree/bindings/net/fsl,fman.yaml
index 7908f67413dea..f0261861f3cb2 100644
--- a/Documentation/devicetree/bindings/net/fsl,fman.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fman.yaml
@@ -78,6 +78,8 @@ properties:
       - description: The first element is associated with the event interrupts.
       - description: the second element is associated with the error interrupts.
 
+  dma-coherent: true
+
   fsl,qman-channel-range:
     $ref: /schemas/types.yaml#/definitions/uint32-array
     description:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v3 2/2] dt-bindings: net: fsl,fman: add ptimer-handle property
  2024-07-04 16:17 [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property Frank Li
@ 2024-07-04 16:17 ` Frank Li
  2024-07-08 17:10 ` [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2024-07-04 16:17 UTC (permalink / raw)
  To: Madalin Bucur, Sean Anderson, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Richard Cochran,
	open list:FREESCALE QORIQ DPAA FMAN DRIVER,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Add ptimer-handle property to link to ptp-timer node handle.
Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: fman@1a00000: 'ptimer-handle' do not match any of the regexes: '^ethernet@[a-f0-9]+$', '^mdio@[a-f0-9]+$', '^muram@[a-f0-9]+$', '^phc@[a-f0-9]+$', '^port@[a-f0-9]+$', 'pinctrl-[0-9]+'

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- none
Change from v1 to v2
- Add Rob's review tag
---
 Documentation/devicetree/bindings/net/fsl,fman.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/fsl,fman.yaml b/Documentation/devicetree/bindings/net/fsl,fman.yaml
index f0261861f3cb2..9bbf39ef31a25 100644
--- a/Documentation/devicetree/bindings/net/fsl,fman.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fman.yaml
@@ -80,6 +80,10 @@ properties:
 
   dma-coherent: true
 
+  ptimer-handle:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: see ptp/fsl,ptp.yaml
+
   fsl,qman-channel-range:
     $ref: /schemas/types.yaml#/definitions/uint32-array
     description:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property
  2024-07-04 16:17 [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property Frank Li
  2024-07-04 16:17 ` [PATCH v3 2/2] dt-bindings: net: fsl,fman: add ptimer-handle property Frank Li
@ 2024-07-08 17:10 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-07-08 17:10 UTC (permalink / raw)
  To: Frank Li
  Cc: Madalin Bucur, Sean Anderson, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Conor Dooley,
	open list:FREESCALE QORIQ DPAA FMAN DRIVER,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Thu, Jul 04, 2024 at 12:17:30PM -0400, Frank Li wrote:
> Add dma-coherent property to fix below warning.
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: fman@1a00000: 'dma-coherent', 'ptimer-handle' do not match any of the regexes: '^ethernet@[a-f0-9]+$', '^mdio@[a-f0-9]+$', '^muram@[a-f0-9]+$', '^phc@[a-f0-9]+$', '^port@[a-f0-9]+$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/net/fsl,fman.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v2 to v3
> - Fix missed one rob's comments about 'dma-coherent property' in commit

What about the subject?

> message.
> Change from v1 to v2
> - Fix paste wrong warning mesg.
> ---
>  Documentation/devicetree/bindings/net/fsl,fman.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-08 17:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-04 16:17 [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property Frank Li
2024-07-04 16:17 ` [PATCH v3 2/2] dt-bindings: net: fsl,fman: add ptimer-handle property Frank Li
2024-07-08 17:10 ` [PATCH v3 1/2] dt-bindings: net: fsl,fman: allow dma-coherence property Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).