From: Danielle Ratson <danieller@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <idosch@nvidia.com>, <petrm@nvidia.com>,
<ecree.xilinx@gmail.com>, <linux-kernel@vger.kernel.org>,
<danieller@nvidia.com>
Subject: [PATCH net-next] net: ethtool: Monotonically increase the message sequence number
Date: Thu, 11 Jul 2024 11:09:34 +0300 [thread overview]
Message-ID: <20240711080934.2071869-1-danieller@nvidia.com> (raw)
Currently, during the module firmware flashing process, unicast
notifications are sent from the kernel using the same sequence number,
making it impossible for user space to track missed notifications.
Monotonically increase the message sequence number, so the order of
notifications could be tracked effectively.
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
net/ethtool/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/module.c b/net/ethtool/module.c
index aba78436d350..6988e07bdcd6 100644
--- a/net/ethtool/module.c
+++ b/net/ethtool/module.c
@@ -488,7 +488,7 @@ ethnl_module_fw_flash_ntf(struct net_device *dev,
if (!skb)
return;
- hdr = ethnl_unicast_put(skb, ntf_params->portid, ntf_params->seq,
+ hdr = ethnl_unicast_put(skb, ntf_params->portid, ++ntf_params->seq,
ETHTOOL_MSG_MODULE_FW_FLASH_NTF);
if (!hdr)
goto err_skb;
--
2.45.0
next reply other threads:[~2024-07-11 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 8:09 Danielle Ratson [this message]
2024-07-11 14:09 ` [PATCH net-next] net: ethtool: Monotonically increase the message sequence number Petr Machata
2024-07-11 14:23 ` Petr Machata
2024-07-12 0:43 ` Jakub Kicinski
2024-07-13 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711080934.2071869-1-danieller@nvidia.com \
--to=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).