From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, tariqt@nvidia.com, rrameshbabu@nvidia.com,
saeedm@nvidia.com, yuehaibing@huawei.com,
jacob.e.keller@intel.com, afaris@nvidia.com
Subject: Re: [PATCH net-next] eth: mlx5: let NETIF_F_NTUPLE float when ARFS is not enabled
Date: Thu, 11 Jul 2024 14:30:40 +0100 [thread overview]
Message-ID: <20240711133040.GD8788@kernel.org> (raw)
In-Reply-To: <20240710175502.760194-1-kuba@kernel.org>
On Wed, Jul 10, 2024 at 10:55:02AM -0700, Jakub Kicinski wrote:
> ARFS depends on NTUPLE filters, but the inverse is not true.
> Drivers which don't support ARFS commonly still support NTUPLE
> filtering. mlx5 has a Kconfig option to disable ARFS (MLX5_EN_ARFS)
> and does not advertise NTUPLE filters as a feature at all when ARFS
> is compiled out. That's not correct, ntuple filters indeed still work
> just fine (as long as MLX5_EN_RXNFC is enabled).
>
> This is needed to make the RSS test not skip all RSS context
> related testing.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2024-07-11 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 17:55 [PATCH net-next] eth: mlx5: let NETIF_F_NTUPLE float when ARFS is not enabled Jakub Kicinski
2024-07-11 13:30 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711133040.GD8788@kernel.org \
--to=horms@kernel.org \
--cc=afaris@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).