From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, tariqt@nvidia.com, rrameshbabu@nvidia.com,
saeedm@nvidia.com, yuehaibing@huawei.com, horms@kernel.org,
jacob.e.keller@intel.com, afaris@nvidia.com
Subject: Re: [PATCH net-next v2] eth: mlx5: expose NETIF_F_NTUPLE when ARFS is compiled out
Date: Thu, 11 Jul 2024 16:16:15 -0700 [thread overview]
Message-ID: <20240711161615.123a5008@kernel.org> (raw)
In-Reply-To: <ZpBlOWzyihXUad_V@x130>
On Thu, 11 Jul 2024 16:05:29 -0700 Saeed Mahameed wrote:
> >+#if IS_ENABLED(CONFIG_MLX5_EN_ARFS)
> > netdev->hw_features |= NETIF_F_NTUPLE;
> >+#elif IS_ENABLED(CONFIG_MLX5_EN_RXNFC)
> >+ netdev->features |= NETIF_F_NTUPLE;
>
> Why default ON when RXNFC and OFF when ARFS ?
> Default should be off always, and this needs to be advertised in
> hw_features in both cases.
>
> I think this should be
> #if IS_ENABLED(ARFS) || IS_ENABLED(RXFNC)
> netdev->hw_features |= NTUPLE;
That's what I thought, but on reflection since the filters can be
added, and disable doesn't actually do anything - "fixed on" started
to sound more appropriate. The additional "[fixed]" could also be useful
for troubleshooting, to signal that this is a different situation than
ARFS=y. No hard preference tho.
> Otherwise LGTM
>
> Acked-by: Saeed Mahameed <saeedm@nvidia.com>
Thanks!
next prev parent reply other threads:[~2024-07-11 23:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 22:37 [PATCH net-next v2] eth: mlx5: expose NETIF_F_NTUPLE when ARFS is compiled out Jakub Kicinski
2024-07-11 23:05 ` Saeed Mahameed
2024-07-11 23:16 ` Jakub Kicinski [this message]
2024-07-12 0:06 ` Saeed Mahameed
2024-07-13 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711161615.123a5008@kernel.org \
--to=kuba@kernel.org \
--cc=afaris@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).