From: Jakub Kicinski <kuba@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>, <jiri@resnulli.us>, <horms@kernel.org>,
<rkannoth@marvell.com>, <jdamato@fastly.com>,
<pkshih@realtek.com>, <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next v23 04/13] rtase: Implement the interrupt routine and rtase_poll
Date: Thu, 11 Jul 2024 18:36:40 -0700 [thread overview]
Message-ID: <20240711183640.02241a9a@kernel.org> (raw)
In-Reply-To: <20240710033234.26868-5-justinlai0215@realtek.com>
On Wed, 10 Jul 2024 11:32:25 +0800 Justin Lai wrote:
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +/* Polling 'interrupt' - used by things like netconsole to send skbs
> + * without having to re-enable interrupts. It's not called while
> + * the interrupt routine is executing.
> + */
> +static void rtase_netpoll(struct net_device *dev)
> +{
> + const struct rtase_private *tp = netdev_priv(dev);
> + const struct pci_dev *pdev = tp->pdev;
> +
> + disable_irq(pdev->irq);
> + rtase_interrupt(pdev->irq, dev);
Why do you need to implement a separate netpoll handler?
netpoll is optional, if driver doesn't implement it core
will just core your NAPI handlers with a budget of 0 (to
only clean up Tx, see NAPI documentation).
disable_irq() sleeps, you most definitely can't call it here.
--
pw-bot: cr
next prev parent reply other threads:[~2024-07-12 1:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 3:32 [PATCH net-next v23 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 03/13] rtase: Implement the rtase_down function Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-07-12 1:36 ` Jakub Kicinski [this message]
2024-07-12 8:31 ` Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 05/13] rtase: Implement hardware configuration function Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 07/13] rtase: Implement a function to receive packets Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 08/13] rtase: Implement net_device_ops Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 10/13] rtase: Implement ethtool function Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-07-10 3:32 ` [PATCH net-next v23 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711183640.02241a9a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).