From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8BBE4C62; Mon, 15 Jul 2024 14:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721055569; cv=none; b=hCwJJ4ZUyWqYkxYQfSw684sH+YSsrFH3+hWvR585S3DqUAs8izVM+dm4Yzc+ugtxzF/bu0G+FATeewiIzq0v8v04tSyfMXl8YDyoZFamJ1MkCZVRj1wRm9uJCaNWRymMyk+uPT4tBcfZ+YuNPcNKwz6+23v/hW+BPOaw1PpFU8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721055569; c=relaxed/simple; bh=Czc/8/j1UJ3uadHtlcCbqCzh/BKvAh+WALaaInDEGXA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ec518dhYxFSE4jjUilijYZdhtbFtewqAdFtIaqGmOE7xiCCa2dKl2eegn2otcddwDW2w5ExgRypyxHQaTd83Bu+uF34yUHvch48bYInicAKiFqzr1NBn/GyE+kMMiYVksJsgEN8KFbliJhaHrlsX7AkjD/ELEV9Q2FsSoR8imNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OElLUgnL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OElLUgnL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48F5CC32782; Mon, 15 Jul 2024 14:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721055568; bh=Czc/8/j1UJ3uadHtlcCbqCzh/BKvAh+WALaaInDEGXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OElLUgnLsRq0inC4mUNDR8o/kzoSy4XbVw14Cl5B7g69gp8OV4U3zpNLSBr46nEQe PaiPFWqZ43OQ/YHPXYUd76MGawWnwFPHfz522XqJoASVZ1HxUZ/3Qf6bGjZC+ESXSi EkTd2ApSD9mNLweuV2Y1pvgPOXUxlW764zizHd6TgDfNNXH9KVWdUghsU5FJ/OeKL3 dB2uQ1w8Lwe1DfJ8g4BLoC6GrjhVt6FBhicdhy/YZhlguR4yYFaiBpi08GUZgJqnnu AxCBVi1DTkCtUlwp0QEFAwNkamVFBhSCMyGHrm391x0qBOI2lO4DgyOQaMIS5c3D4y s+2EvuEyiNj9g== Date: Mon, 15 Jul 2024 07:59:26 -0700 From: Jakub Kicinski To: Kory Maincent Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , donald.hunter@gmail.com, danieller@nvidia.com, ecree.xilinx@gmail.com, Thomas Petazzoni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu , Willem de Bruijn , Shannon Nelson , Alexandra Winter Subject: Re: [PATCH net-next v17 13/14] net: ethtool: Add support for tsconfig command to get/set hwtstamp config Message-ID: <20240715075926.7f3e368c@kernel.org> In-Reply-To: <20240709-feature_ptp_netnext-v17-13-b5317f50df2a@bootlin.com> References: <20240709-feature_ptp_netnext-v17-0-b5317f50df2a@bootlin.com> <20240709-feature_ptp_netnext-v17-13-b5317f50df2a@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 09 Jul 2024 15:53:45 +0200 Kory Maincent wrote: > + /* Get the hwtstamp config from netlink */ > + if (tb[ETHTOOL_A_TSCONFIG_TX_TYPES]) { > + ret = ethnl_parse_bitset(&req_tx_type, &mask, > + __HWTSTAMP_TX_CNT, > + tb[ETHTOOL_A_TSCONFIG_TX_TYPES], > + ts_tx_type_names, info->extack); > + if (ret < 0) > + goto err_clock_put; > + > + /* Select only one tx type at a time */ > + if (ffs(req_tx_type) != fls(req_tx_type)) { > + ret = -EINVAL; > + goto err_clock_put; > + } > + > + hwtst_config.tx_type = ffs(req_tx_type) - 1; > + } > + if (tb[ETHTOOL_A_TSCONFIG_RX_FILTERS]) { > + ret = ethnl_parse_bitset(&req_rx_filter, &mask, > + __HWTSTAMP_FILTER_CNT, > + tb[ETHTOOL_A_TSCONFIG_RX_FILTERS], > + ts_rx_filter_names, info->extack); > + if (ret < 0) > + goto err_clock_put; > + > + /* Select only one rx filter at a time */ > + if (ffs(req_rx_filter) != fls(req_rx_filter)) { > + ret = -EINVAL; > + goto err_clock_put; > + } > + > + hwtst_config.rx_filter = ffs(req_rx_filter) - 1; > + } > + if (tb[ETHTOOL_A_TSCONFIG_HWTSTAMP_FLAGS]) { > + ret = nla_get_u32(tb[ETHTOOL_A_TSCONFIG_HWTSTAMP_FLAGS]); > + if (ret < 0) > + goto err_clock_put; > + hwtst_config.flags = ret; > + } We should be tracking mod on these, too. Separately from the provider mod bit, let's not call the driver and send notification if nothing changed. > + ret = net_hwtstamp_validate(&hwtst_config); > + if (ret) > + goto err_clock_put; > + > + /* Disable current time stamping if we try to enable another one */ > + if (mod && (hwtst_config.tx_type || hwtst_config.rx_filter)) { > + struct kernel_hwtstamp_config zero_config = {0}; > + > + ret = dev_set_hwtstamp_phylib(dev, &zero_config, info->extack); > + if (ret < 0) > + goto err_clock_put; > + } > + > + /* Changed the selected hwtstamp source if needed */ > + if (mod) { > + struct hwtstamp_provider *__hwtstamp; > + > + __hwtstamp = rcu_replace_pointer_rtnl(dev->hwtstamp, hwtstamp); > + if (__hwtstamp) > + call_rcu(&__hwtstamp->rcu_head, > + remove_hwtstamp_provider); > + } > + > + ret = dev_set_hwtstamp_phylib(dev, &hwtst_config, info->extack); > + if (ret < 0) > + return ret; We can't unwind to old state here? > + return 1; Driver can change hwtst_config right? "upgrade" the rx_filter to a broader one, IIRC. Shouldn't we reply to the set command with the resulting configuration, in case it changed? Basically provide the same info as the notification would.