* [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()
@ 2024-07-13 13:18 Markus Elfring
2024-07-15 16:01 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2024-07-13 13:18 UTC (permalink / raw)
To: xen-devel, netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Paul Durrant, Wei Liu
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 13 Jul 2024 15:10:15 +0200
Single characters (line breaks) should be put into a sequence.
Thus use the corresponding function “seq_putc”.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/xen-netback/hash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-netback/hash.c
index ff96f22648ef..2d77a7187e1e 100644
--- a/drivers/net/xen-netback/hash.c
+++ b/drivers/net/xen-netback/hash.c
@@ -425,7 +425,7 @@ void xenvif_dump_hash_info(struct xenvif *vif, struct seq_file *m)
for (j = 0; j < n; j++, i++)
seq_printf(m, "%02x ", vif->hash.key[i]);
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
if (vif->hash.size != 0) {
@@ -445,7 +445,7 @@ void xenvif_dump_hash_info(struct xenvif *vif, struct seq_file *m)
for (j = 0; j < n; j++, i++)
seq_printf(m, "%4u ", mapping[i]);
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
}
}
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()
2024-07-13 13:18 [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info() Markus Elfring
@ 2024-07-15 16:01 ` Jakub Kicinski
2024-07-15 20:24 ` Christophe JAILLET
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2024-07-15 16:01 UTC (permalink / raw)
To: Markus Elfring
Cc: xen-devel, netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Paolo Abeni, Paul Durrant, Wei Liu, LKML
On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote:
> Single characters (line breaks) should be put into a sequence.
> Thus use the corresponding function “seq_putc”.
>
> This issue was transformed by using the Coccinelle software.
I prefer to only merge trivial changes like this if maintainer
indicates their support by acking them. Since the merge window
has opened we can't wait and see so I'm marking this patch and
your pktgen patch as deferred.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()
2024-07-15 16:01 ` Jakub Kicinski
@ 2024-07-15 20:24 ` Christophe JAILLET
2024-07-15 20:39 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Christophe JAILLET @ 2024-07-15 20:24 UTC (permalink / raw)
To: Jakub Kicinski
Cc: xen-devel, netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Paolo Abeni, Paul Durrant, Wei Liu, LKML, Markus Elfring
Le 15/07/2024 à 18:01, Jakub Kicinski a écrit :
> On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote:
>> Single characters (line breaks) should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>
>> This issue was transformed by using the Coccinelle software.
>
> I prefer to only merge trivial changes like this if maintainer
> indicates their support by acking them. Since the merge window
> has opened we can't wait and see so I'm marking this patch and
> your pktgen patch as deferred.
>
>
Hi Jakub,
Most of the time, this kind of modification is useless because it is
already done by the compiler, see [1].
CJ
[1]:
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/seq_file.h#L123
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()
2024-07-15 20:24 ` Christophe JAILLET
@ 2024-07-15 20:39 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-07-15 20:39 UTC (permalink / raw)
To: Christophe JAILLET
Cc: xen-devel, netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Paolo Abeni, Paul Durrant, Wei Liu, LKML, Markus Elfring
On Mon, 15 Jul 2024 22:24:39 +0200 Christophe JAILLET wrote:
> Most of the time, this kind of modification is useless because it is
> already done by the compiler, see [1].
GTK, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-15 20:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-13 13:18 [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info() Markus Elfring
2024-07-15 16:01 ` Jakub Kicinski
2024-07-15 20:24 ` Christophe JAILLET
2024-07-15 20:39 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).