Re: [PATCH ipsec-next v5 17/17] xfrm: iptfs: add tracepoint functionality

[kernel test robot <lkp@intel.com>]

Hi Christian,

kernel test robot noticed the following build errors:

[auto build test ERROR on klassert-ipsec-next/master]
[also build test ERROR on next-20240715]
[cannot apply to klassert-ipsec/master netfilter-nf/main linus/master nf-next/master v6.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Hopps/xfrm-config-add-CONFIG_XFRM_IPTFS/20240715-042948
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
patch link:    https://lore.kernel.org/r/20240714202246.1573817-18-chopps%40chopps.org
patch subject: [PATCH ipsec-next v5 17/17] xfrm: iptfs: add tracepoint functionality
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20240715/202407151936.lWZK9Xnp-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240715/202407151936.lWZK9Xnp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407151936.lWZK9Xnp-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:102,
                    from net/xfrm/trace_iptfs.h:218,
                    from net/xfrm/xfrm_iptfs.c:445:
   include/trace/../../net/xfrm/trace_iptfs.h: In function 'trace_event_raw_event_iptfs_egress_recv':
>> include/trace/../../net/xfrm/trace_iptfs.h:46:42: error: assignment to 'u32' {aka 'unsigned int'} from 'sk_buff_data_t' {aka 'unsigned char *'} makes integer from pointer without a cast [-Wint-conversion]
      46 |                            __entry->tail = skb->tail;
         |                                          ^
   include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
     402 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:22:1: note: in expansion of macro 'TRACE_EVENT'
      22 | TRACE_EVENT(iptfs_egress_recv,
         | ^~~~~~~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:40:13: note: in expansion of macro 'TP_fast_assign'
      40 |             TP_fast_assign(__entry->skb = skb;
         |             ^~~~~~~~~~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:47:41: error: assignment to 'u32' {aka 'unsigned int'} from 'sk_buff_data_t' {aka 'unsigned char *'} makes integer from pointer without a cast [-Wint-conversion]
      47 |                            __entry->end = skb->end;
         |                                         ^
   include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
     402 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:22:1: note: in expansion of macro 'TRACE_EVENT'
      22 | TRACE_EVENT(iptfs_egress_recv,
         | ^~~~~~~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:40:13: note: in expansion of macro 'TP_fast_assign'
      40 |             TP_fast_assign(__entry->skb = skb;
         |             ^~~~~~~~~~~~~~
   In file included from include/trace/define_trace.h:103:
   include/trace/../../net/xfrm/trace_iptfs.h: In function 'perf_trace_iptfs_egress_recv':
>> include/trace/../../net/xfrm/trace_iptfs.h:46:42: error: assignment to 'u32' {aka 'unsigned int'} from 'sk_buff_data_t' {aka 'unsigned char *'} makes integer from pointer without a cast [-Wint-conversion]
      46 |                            __entry->tail = skb->tail;
         |                                          ^
   include/trace/perf.h:51:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
      51 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:22:1: note: in expansion of macro 'TRACE_EVENT'
      22 | TRACE_EVENT(iptfs_egress_recv,
         | ^~~~~~~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:40:13: note: in expansion of macro 'TP_fast_assign'
      40 |             TP_fast_assign(__entry->skb = skb;
         |             ^~~~~~~~~~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:47:41: error: assignment to 'u32' {aka 'unsigned int'} from 'sk_buff_data_t' {aka 'unsigned char *'} makes integer from pointer without a cast [-Wint-conversion]
      47 |                            __entry->end = skb->end;
         |                                         ^
   include/trace/perf.h:51:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
      51 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:22:1: note: in expansion of macro 'TRACE_EVENT'
      22 | TRACE_EVENT(iptfs_egress_recv,
         | ^~~~~~~~~~~
   include/trace/../../net/xfrm/trace_iptfs.h:40:13: note: in expansion of macro 'TP_fast_assign'
      40 |             TP_fast_assign(__entry->skb = skb;
         |             ^~~~~~~~~~~~~~


vim +46 include/trace/../../net/xfrm/trace_iptfs.h

    21	
    22	TRACE_EVENT(iptfs_egress_recv,
    23		    TP_PROTO(struct sk_buff *skb, struct xfrm_iptfs_data *xtfs, u16 blkoff),
    24		    TP_ARGS(skb, xtfs, blkoff),
    25		    TP_STRUCT__entry(__field(struct sk_buff *, skb)
    26				     __field(void *, head)
    27				     __field(void *, head_pg_addr)
    28				     __field(void *, pg0addr)
    29				     __field(u32, skb_len)
    30				     __field(u32, data_len)
    31				     __field(u32, headroom)
    32				     __field(u32, tailroom)
    33				     __field(u32, tail)
    34				     __field(u32, end)
    35				     __field(u32, pg0off)
    36				     __field(u8, head_frag)
    37				     __field(u8, frag_list)
    38				     __field(u8, nr_frags)
    39				     __field(u16, blkoff)),
    40		    TP_fast_assign(__entry->skb = skb;
    41				   __entry->head = skb->head;
    42				   __entry->skb_len = skb->len;
    43				   __entry->data_len = skb->data_len;
    44				   __entry->headroom = skb_headroom(skb);
    45				   __entry->tailroom = skb_tailroom(skb);
  > 46				   __entry->tail = skb->tail;
    47				   __entry->end = skb->end;
    48				   __entry->head_frag = skb->head_frag;
    49				   __entry->frag_list = (bool)skb_shinfo(skb)->frag_list;
    50				   __entry->nr_frags = skb_shinfo(skb)->nr_frags;
    51				   __entry->blkoff = blkoff;
    52				   __entry->head_pg_addr = page_address(virt_to_head_page(skb->head));
    53				   __entry->pg0addr = (__entry->nr_frags
    54						       ? page_address(netmem_to_page(skb_shinfo(skb)->frags[0].netmem))
    55						       : NULL);
    56				   __entry->pg0off = (__entry->nr_frags
    57						      ? skb_shinfo(skb)->frags[0].offset
    58						      : 0);
    59			    ),
    60		    TP_printk("EGRESS: skb=%p len=%u data_len=%u headroom=%u head_frag=%u frag_list=%u nr_frags=%u blkoff=%u\n\t\ttailroom=%u tail=%u end=%u head=%p hdpgaddr=%p pg0->addr=%p pg0->data=%p pg0->off=%u",
    61			      __entry->skb, __entry->skb_len, __entry->data_len, __entry->headroom,
    62			      __entry->head_frag, __entry->frag_list, __entry->nr_frags, __entry->blkoff,
    63			      __entry->tailroom, __entry->tail, __entry->end, __entry->head,
    64			      __entry->head_pg_addr, __entry->pg0addr, __entry->pg0addr + __entry->pg0off,
    65			      __entry->pg0off)
    66		)
    67	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki