netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Allison Henderson <allison.henderson@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
	<rds-devel@oss.oracle.com>, <linux-kernel@vger.kernel.org>,
	Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: [PATCH] RDMA/rds: Remove duplicate MODULE_LICENSE() from ib.c
Date: Wed, 17 Jul 2024 16:45:36 -0700	[thread overview]
Message-ID: <20240717-ml-net-rds-rdma-v1-1-5cc471a5e20f@quicinc.com> (raw)

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. One strategy for identifying such
modules is to search for files which have a MODULE_LICENSE() but which
do not have a MODULE_DESCRIPTION(). net/rds/ib.c is one such file. And
its product, ib.o, is a component of the rds_rdma module via:

obj-$(CONFIG_RDS_RDMA) += rds_rdma.o
rds_rdma-y :=	rdma_transport.o \
			ib.o ib_cm.o ib_recv.o ib_ring.o ib_send.o ib_stats.o \
			ib_sysctl.o ib_rdma.o ib_frmr.o

Interestingly, when CONFIG_RDS_RDMA=m, the missing description warning
is NOT emitted by modpost. This is because rdma_transport.c contains a
MODULE_DESCRIPTION() that describes this module. And in addition,
rdma_transport.c contains a MODULE_LICENSE() for this module.

Since rdma_transport.c already contains both the MODULE_LICENSE() and
the MODULE_DESCRIPTION() for the rds_rdma module, remove the duplicate
MODULE_LICENSE() from ib.c

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 net/rds/ib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/rds/ib.c b/net/rds/ib.c
index 9826fe7f9d00..4a33f911673b 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -603,5 +603,3 @@ int rds_ib_init(void)
 out:
 	return ret;
 }
-
-MODULE_LICENSE("GPL");

---
base-commit: 797012914d2d031430268fe512af0ccd7d8e46ef
change-id: 20240717-ml-net-rds-rdma-ac7608e59cb0


             reply	other threads:[~2024-07-17 23:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 23:45 Jeff Johnson [this message]
2024-07-18  8:44 ` [PATCH] RDMA/rds: Remove duplicate MODULE_LICENSE() from ib.c Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717-ml-net-rds-rdma-v1-1-5cc471a5e20f@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=allison.henderson@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).