From: Jakub Kicinski <kuba@kernel.org>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<michal.simek@amd.com>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <git@amd.com>,
Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Subject: Re: [PATCH net-next] net: axienet: Fix coding style issues
Date: Wed, 17 Jul 2024 17:00:43 -0700 [thread overview]
Message-ID: <20240717170043.45aaf7e2@kernel.org> (raw)
In-Reply-To: <1721242483-3121341-1-git-send-email-radhey.shyam.pandey@amd.com>
On Thu, 18 Jul 2024 00:24:43 +0530 Radhey Shyam Pandey wrote:
> Replace all occurences of (1<<x) by BIT(x) to get rid of checkpatch.pl
> "CHECK" output "Prefer using the BIT macro".
FWIW the BIT() thing is a matter of preference, we don't enforce it
strictly in networking, it may not be worth patching. Up to you.
next prev parent reply other threads:[~2024-07-18 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 18:54 [PATCH net-next] net: axienet: Fix coding style issues Radhey Shyam Pandey
2024-07-17 20:38 ` Andrew Lunn
2024-07-18 0:00 ` Jakub Kicinski [this message]
2024-07-18 11:45 ` Jiri Pirko
2024-07-18 9:06 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717170043.45aaf7e2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=appana.durga.rao@xilinx.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).