From: vtpieter@gmail.com
To: devicetree@vger.kernel.org, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Cc: o.rempel@pengutronix.de, Pieter Van Trappen <pieter.van.trappen@cern.ch>
Subject: [PATCH 4/4] net: dsa: microchip: ksz9477: correct description of WoL functions
Date: Wed, 17 Jul 2024 21:37:25 +0200 [thread overview]
Message-ID: <20240717193725.469192-5-vtpieter@gmail.com> (raw)
In-Reply-To: <20240717193725.469192-4-vtpieter@gmail.com>
From: Pieter Van Trappen <pieter.van.trappen@cern.ch>
Correct KSZ9477 WoL function description, found when evaluating it for
usage at KSZ8795 family of switches.
Signed-off-by: Pieter Van Trappen <pieter.van.trappen@cern.ch>
---
drivers/net/dsa/microchip/ksz9477.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c
index 425e20daf1e9..1344b60ee2c3 100644
--- a/drivers/net/dsa/microchip/ksz9477.c
+++ b/drivers/net/dsa/microchip/ksz9477.c
@@ -95,9 +95,9 @@ static int ksz9477_handle_wake_reason(struct ksz_device *dev, int port)
* @port: The port number.
* @wol: Pointer to ethtool Wake-on-LAN settings structure.
*
- * This function checks the PME Pin Control Register to see if PME Pin Output
- * Enable is set, indicating PME is enabled. If enabled, it sets the supported
- * and active WoL flags.
+ * This function checks the PME 'wakeup-source' property from the
+ * device tree. If enabled, it sets the supported and active WoL
+ * flags.
*/
void ksz9477_get_wol(struct ksz_device *dev, int port,
struct ethtool_wolinfo *wol)
@@ -135,7 +135,7 @@ void ksz9477_get_wol(struct ksz_device *dev, int port,
*
* This function configures Wake-on-LAN (WoL) settings for a specified port.
* It validates the provided WoL options, checks if PME is enabled via the
- * switch's PME Pin Control Register, clears any previous wake reasons,
+ * switch's device tree property, clears any previous wake reasons,
* and sets the Magic Packet flag in the port's PME control register if
* specified.
*
--
2.43.0
next prev parent reply other threads:[~2024-07-17 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 19:37 [PATCH 0/4] net: dsa: microchip: ksz8795: add Wake on LAN support vtpieter
2024-07-17 19:37 ` [PATCH 1/4] dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag vtpieter
2024-07-17 19:37 ` [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support vtpieter
2024-07-17 19:37 ` [PATCH 3/4] net: dsa: microchip: check erratum workaround through indirect register read vtpieter
2024-07-17 19:37 ` vtpieter [this message]
2024-07-19 13:52 ` [PATCH 4/4] net: dsa: microchip: ksz9477: correct description of WoL functions Oleksij Rempel
2024-07-18 2:24 ` [PATCH 3/4] net: dsa: microchip: check erratum workaround through indirect register read Andrew Lunn
2024-07-18 13:45 ` Pieter
2024-07-19 13:46 ` [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support Oleksij Rempel
2024-07-20 12:44 ` Pieter
2024-07-19 12:36 ` [PATCH 1/4] dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag Oleksij Rempel
2024-07-23 2:42 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717193725.469192-5-vtpieter@gmail.com \
--to=vtpieter@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pieter.van.trappen@cern.ch \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).