From: Jakub Kicinski <kuba@kernel.org>
To: Jeongjun Park <aha310510@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
jiri@resnulli.us,
syzbot+113b65786d8662e21ff7@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: annotate data race around dev->flags in __dev_change_flags
Date: Mon, 29 Jul 2024 11:36:11 -0700 [thread overview]
Message-ID: <20240729113611.6433d447@kernel.org> (raw)
In-Reply-To: <20240729163326.16386-1-aha310510@gmail.com>
On Tue, 30 Jul 2024 01:33:26 +0900 Jeongjun Park wrote:
> According to KCSAN report, there is a read/write race between
> __dev_change_flags and netif_is_bond_master for dev->flags.
>
> Thereforce, __dev_change_flags() needs protection.
I told you already that this just silences the warning, you need to
provide real analysis and explanation of why this is right.
https://lore.kernel.org/all/20240729074132.6edec347@kernel.org/
--
pw-bot: reject
prev parent reply other threads:[~2024-07-29 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 16:33 [PATCH net] net: annotate data race around dev->flags in __dev_change_flags Jeongjun Park
2024-07-29 17:46 ` Eric Dumazet
2024-07-29 18:36 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729113611.6433d447@kernel.org \
--to=kuba@kernel.org \
--cc=aha310510@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+113b65786d8662e21ff7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).