From: Tariq Toukan <tariqt@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Jay Vosburgh" <jv@jvosburgh.net>,
Andy Gospodarek <andy@greyhouse.net>
Cc: <netdev@vger.kernel.org>, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Jianbo Liu <jianbol@nvidia.com>, Cosmin Ratiu <cratiu@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH net 2/4] bonding: call xfrm state xdo_dev_state_free after deletion
Date: Mon, 29 Jul 2024 15:44:03 +0300 [thread overview]
Message-ID: <20240729124406.1824592-3-tariqt@nvidia.com> (raw)
In-Reply-To: <20240729124406.1824592-1-tariqt@nvidia.com>
From: Jianbo Liu <jianbol@nvidia.com>
Need to call xdo_dev_state_free API to avoid hardware resource leakage
when deleting all SAs from old active real interface.
Fixes: 9a5605505d9c ("bonding: Add struct bond_ipesc to manage SA")
Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/bonding/bond_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 3b880ff2b82a..551cebfa3261 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -581,6 +581,8 @@ static void bond_ipsec_del_sa_all(struct bonding *bond)
__func__);
} else {
slave->dev->xfrmdev_ops->xdo_dev_state_delete(ipsec->xs);
+ if (slave->dev->xfrmdev_ops->xdo_dev_state_free)
+ slave->dev->xfrmdev_ops->xdo_dev_state_free(ipsec->xs);
}
ipsec->xs->xso.real_dev = NULL;
}
--
2.44.0
next prev parent reply other threads:[~2024-07-29 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 12:44 [PATCH net 0/4] Fixes for IPsec over bonding Tariq Toukan
2024-07-29 12:44 ` [PATCH net 1/4] bonding: implement xfrm state xdo_dev_state_free API Tariq Toukan
2024-07-31 3:27 ` Hangbin Liu
2024-07-31 6:52 ` Jianbo Liu
2024-07-29 12:44 ` Tariq Toukan [this message]
2024-07-31 3:36 ` [PATCH net 2/4] bonding: call xfrm state xdo_dev_state_free after deletion Hangbin Liu
2024-07-31 7:08 ` Jianbo Liu
2024-07-29 12:44 ` [PATCH net 3/4] bonding: extract the use of real_device into local variable Tariq Toukan
2024-07-29 12:44 ` [PATCH net 4/4] bonding: change ipsec_lock from spin lock to mutex Tariq Toukan
2024-07-30 11:28 ` Paolo Abeni
2024-07-31 6:29 ` Jianbo Liu
2024-07-31 3:20 ` [PATCH net 0/4] Fixes for IPsec over bonding Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729124406.1824592-3-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andy@greyhouse.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).