From: Jakub Kicinski <kuba@kernel.org>
To: 백광록 <zester926@gmail.com>
Cc: netdev@vger.kernel.org, mkubecek@suse.cz, ahmed.zaki@intel.com,
ecree@solarflare.com
Subject: Re: [PATCH net] ethtool: fix argument check in do_srxfh function to prevent segmentation fault
Date: Mon, 29 Jul 2024 19:04:33 -0700 [thread overview]
Message-ID: <20240729190433.06e1bb9f@kernel.org> (raw)
In-Reply-To: <CAHcxVNNRRCMtT0AyNk4OTcqBn6wWTk37SJw9eWChKhxGRCjUCQ@mail.gmail.com>
On Sat, 27 Jul 2024 22:39:46 +0900 백광록 wrote:
> Subject: [PATCH net] ethtool: fix argument check in do_srxfh function to prevent segmentation fault
Patch makes sense, but two nit picks:
1) please repost with subject:
[PATCH ethtool v2] ethtool: fix argument check in do_srxfh function to prevent segmentation fault
this is a user space CLI patch, not a kernel patch hence ethtool not
net in the brackets.
> Ensure that do_srxfh function in ethtool.c checks for the presence of
> additional arguments when context or xfrm parameter is provided before
> performing strcmp. This prevents segmentation faults caused by missing
> arguments.
>
> Without this patch, running 'ethtool -X DEVNAME [ context | xfrm ]' without
> additional arguments results in a segmentation fault due to an invalid
> strcmp operation.
>
> Fixes: f5d55b967e0c ("ethtool: add support for extra RSS contexts and
> RSS steering filters")
2) Please prevent line wrapping of Fixes tags
prev parent reply other threads:[~2024-07-30 2:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-27 13:39 [PATCH net] ethtool: fix argument check in do_srxfh function to prevent segmentation fault 백광록
2024-07-30 2:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729190433.06e1bb9f@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=ecree@solarflare.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=zester926@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).