From: Jakub Kicinski <kuba@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>, <jiri@resnulli.us>, <horms@kernel.org>,
<rkannoth@marvell.com>, <jdamato@fastly.com>,
<pkshih@realtek.com>, <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next v25 02/13] rtase: Implement the .ndo_open function
Date: Mon, 29 Jul 2024 19:15:59 -0700 [thread overview]
Message-ID: <20240729191559.1683ec63@kernel.org> (raw)
In-Reply-To: <20240729062121.335080-3-justinlai0215@realtek.com>
On Mon, 29 Jul 2024 14:21:10 +0800 Justin Lai wrote:
> + page = page_pool_dev_alloc_pages(tp->page_pool);
> + if (!page) {
> + netdev_err(tp->dev, "failed to alloc page\n");
> + goto err_out;
> + }
> +
> + buf_addr = page_address(page);
> + mapping = page_pool_get_dma_addr(page);
> +
> + skb = build_skb(buf_addr, PAGE_SIZE);
Don't build_skb() before packet was received.
One of the benefits of build_skb() is that the skb is supposed
to be more likely to be still in CPU cache.
next prev parent reply other threads:[~2024-07-30 2:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 6:21 [PATCH net-next v25 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-07-29 9:33 ` Markus Elfring
2024-07-29 11:31 ` Justin Lai
2024-07-29 13:00 ` Andrew Lunn
2024-07-29 16:44 ` Markus Elfring
2024-07-29 6:21 ` [PATCH net-next v25 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-07-30 2:15 ` Jakub Kicinski [this message]
2024-07-30 9:24 ` Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 03/13] rtase: Implement the rtase_down function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 05/13] rtase: Implement hardware configuration function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-07-30 2:14 ` Jakub Kicinski
2024-07-30 9:27 ` Justin Lai
2024-07-30 14:12 ` Jakub Kicinski
2024-07-30 19:34 ` Heiner Kallweit
2024-07-29 6:21 ` [PATCH net-next v25 07/13] rtase: Implement a function to receive packets Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 08/13] rtase: Implement net_device_ops Justin Lai
2024-07-29 10:29 ` Joe Damato
2024-07-29 11:39 ` Justin Lai
2024-07-29 11:56 ` Joe Damato
2024-07-29 12:26 ` Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 10/13] rtase: Implement ethtool function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729191559.1683ec63@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).